Pulp

While investigating https://pulp.plan.io/issues/7010 (Solution was to replace import_tasks with include_tasks).

I noticed we have 2 other import_tasks tasks that use variables, albeit very differently. And are therefore likely to fail.

pulp_webserver has:

- import_tasks: firewalld.yml
  when: pulp_configure_firewall in ['firewalld', 'auto']

(This would result in the firewall not being configured.)

And pulp_devel has:

- import_tasks: galaxy_ui.yml
  when: pulp_install_plugins_normalized['galaxy-ng'] is defined
  become: true

(Galaxy UI would not be built.)

My recollection is that:

• when: conditions are discouraged for static imports (rather than dynamic includes)
• We've had them break when users call include_role, rather than specifying a role: list.

I am writing this single issue, since pulp_devel is less meticulously maintained since it is only meant for (plugin) devs.