firewall may fail to be configured for certain pulp_installer users
While investigating https://pulp.plan.io/issues/7010
(Solution was to replace
I noticed we have 2 other
import_tasks tasks that use variables, albeit very differently. And are therefore likely to fail.
- import_tasks: firewalld.yml when: pulp_configure_firewall in ['firewalld', 'auto']
(This would result in the firewall not being configured.)
And pulp_devel has:
- import_tasks: galaxy_ui.yml when: pulp_install_plugins_normalized['galaxy-ng'] is defined become: true
(Galaxy UI would not be built.)
My recollection is that:
when:conditions are discouraged for static imports (rather than dynamic includes)
- We've had them break when users call
include_role, rather than specifying a
I am writing this single issue, since pulp_devel is less meticulously maintained since it is only meant for (plugin) devs.
Problem: firewall may fail to be configured for certain pulp_installer users
Similarly, the Galaxy NG WebUI may not build.
Solution: Convert all the import_tasks with when conditions to include_tasks.
#6 Updated by Anonymous about 5 hours ago
- Status changed from POST to MODIFIED
Applied in changeset ansible-pulp|d7631062c588bf57b39424d23413c6ab3c96805a.
Please register to edit this issue