Project

Profile

Help

Issue #7062

firewall may fail to be configured for certain pulp_installer users

Added by mdepaulo@redhat.com 2 days ago. Updated about 5 hours ago.

Status:
MODIFIED
Priority:
Normal
Category:
Installer
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 76

Description

While investigating https://pulp.plan.io/issues/7010 (Solution was to replace import_tasks with include_tasks).

I noticed we have 2 other import_tasks tasks that use variables, albeit very differently. And are therefore likely to fail.

pulp_webserver has:

- import_tasks: firewalld.yml
  when: pulp_configure_firewall in ['firewalld', 'auto']

(This would result in the firewall not being configured.)

And pulp_devel has:

- import_tasks: galaxy_ui.yml
  when: pulp_install_plugins_normalized['galaxy-ng'] is defined
  become: true

(Galaxy UI would not be built.)

My recollection is that:

  • when: conditions are discouraged for static imports (rather than dynamic includes)
  • We've had them break when users call include_role, rather than specifying a role: list.

I am writing this single issue, since pulp_devel is less meticulously maintained since it is only meant for (plugin) devs.


Related issues

Related to Pulp - Issue #7010: Apache is not being installedMODIFIED<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

Associated revisions

Revision d7631062 View on GitHub
Added by Mike DePaulo about 8 hours ago

Problem: firewall may fail to be configured for certain pulp_installer users

Similarly, the Galaxy NG WebUI may not build.

Solution: Convert all the import_tasks with when conditions to include_tasks.

fixes: #7062 firewall may fail to be configured for certain pulp_installer users https://pulp.plan.io/issues/7062

Revision acc42202 View on GitHub
Added by Mike DePaulo about 5 hours ago

Update pulp_installer.

re: #7062 Galaxy NG WebUI would not build on pulplift. https://github.com/pulp/pulp_installer/pull/355

History

#1 Updated by mdepaulo@redhat.com 2 days ago

  • Related to Issue #7010: Apache is not being installed added

#2 Updated by mdepaulo@redhat.com 2 days ago

  • Subject changed from firewall may fail to be configured when using ansible include_role to firewall may fail to be configured for certain pulp_installer users

#3 Updated by dkliban@redhat.com 1 day ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 76

#4 Updated by mdepaulo@redhat.com about 9 hours ago

  • Assignee set to mdepaulo@redhat.com

#5 Updated by pulpbot about 8 hours ago

  • Status changed from NEW to POST

#6 Updated by Anonymous about 5 hours ago

  • Status changed from POST to MODIFIED

Please register to edit this issue

Also available in: Atom PDF