Issue #682: publish_repo failures that do not raise an exception are marked as successful - Pulp

Actions

Send by e-mail Copy link

Issue #682

closed

publish_repo failures that do not raise an exception are marked as successful

Added by bcourt about 9 years ago. Updated almost 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

bcourt

Category:

Sprint/Milestone:

Start date:

Due date:

Estimated time:

Severity:

3. High

Version:

2.5

Platform Release:

2.6.2

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Pulp 2

Sprint:

Quarter:

Description

Description of problem:

When a distributor has it's publish_repo method called and the publish report return indicates a failure the task is marked as completing successfully. If the publish_repo method raises an exception the task is marked properly as failed.

+ This bug was cloned from Bugzilla Bug #1186920 +

Actions

Copy link

Updated by dkliban@redhat.com about 9 years ago

***** Bug 1193131 has been marked as a duplicate of this bug. ***

+ This comment was cloned from Bugzilla #1186920 comment 1 +

Actions

Copy link

Updated by bmbouter about 9 years ago

Severity changed from High to 3. High

Actions

Copy link

Updated by bcourt about 9 years ago

Assignee set to bcourt

Actions

Copy link

Updated by bcourt about 9 years ago

Status changed from NEW to POST
Platform Release set to 2.6.2

https://github.com/pulp/pulp/pull/1774

Added by bcourt about 9 years ago

Revision cb30af0a | View on GitHub

Ensure that if a publish_report is failed the task is marked as a failure.

fixes #682

Added by bcourt about 9 years ago

Revision cb30af0a | View on GitHub

Ensure that if a publish_report is failed the task is marked as a failure.

fixes #682

Actions

Copy link

Updated by bcourt about 9 years ago

Status changed from POST to MODIFIED

Actions

Copy link

Updated by bcourt about 9 years ago

% Done changed from 0 to 100

Applied in changeset pulp|cb30af0a93089f6145f073933c46f1fcd6fa2ad9.

Actions

Copy link

Updated by dkliban@redhat.com almost 9 years ago

Status changed from MODIFIED to 5

Actions

Copy link

Updated by pthomas@redhat.com almost 9 years ago

Status changed from 5 to 6

Verified

[root@mgmt12 puppet]# rpm -qa pulp-server
pulp-server-2.6.2-0.2.beta.el6.noarch
[root@mgmt12 puppet]# 
<\pre>
task is marked correctly as failed

<pre>

u'/var/lib/pulp/published/yum/master/yum_distributor/rad-5Client/1432052214.08/c
ups-devel-1.3.7-32.el5_11.i386.rpm'"),
(u'/var/lib/pulp/published/yum/master/yum_distributor/rad-5Client/1432052214.08/
cyrus-sasl-devel-2.1.22-5.el5.i386.rpm',
u'/var/lib/pulp/working/repos/rad-5Client/distributors/yum_distributor/cyrus-sas
l-devel-2.1.22-5.el5.i386.rpm', "[Errno 13] Permission denied:
u'/var/lib/pulp/published/yum/master/yum_distributor/rad-5Client/1432052214.08/c
yrus-sasl-devel-2.1.22-5.el5.i386.rpm'"),
(u'/var/lib/pulp/published/yum/master/yum_distributor/rad-5Client/1432052214.08/
sblim-sfcc-devel-2.2.2-51.el5.x86_64.rpm',
u'/var/lib/pulp/working/repos/rad-5Client/distributors/yum_distributor/sblim-sfc
c-devel-2.2.2-51.el5.x86_64.rpm', "[Errno 13] Permission denied:
u'/var/lib/pulp/published/yum/master/yum_distributor/rad-5Client/1432052214.08/s
blim-sfcc-devel-2.2.2-51.el5.x86_64.rpm'")]

Task Failed

/pre>

<pre>
Operations:  publish
Resources:   rad-5Client (repository)
State:       Failed
Start Time:  2015-05-25T16:04:08Z
Finish Time: 2015-05-25T16:04:09Z
Task Id:     5b7839f9-9d98-4e80-b8f2-5c5f2ff20eac

Actions

Copy link

#10