Actions
Issue #6644
closed
Issue #6623: pulpcore and plugin pre-flight check seems to not be enforcing and then installer fails at collectstatic
pre-flight check does not check plugins that are installed but not listed in pulp_install_plugins
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
Installer - Moved to GitHub issues
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 72
Quarter:
Description
Consider the following scenario:
- Pulp 3.2.1, pulp-file 0.2, & pulp-container 1.2.0 were installed.
- The user runs the latest pulp_installer (3.3) with the following pulp_install_plugins, which is missing pulp_container:
pulp_install_plugins:
pulp-file:
version: "0.3"
This causes the following to happen
- The pre-flight (
pip-compile) check determines that pulp-file 0.3 is compatible with pulpcore 3.3.0, and passes. - It sees pulp-container 1.2.0 in the old requirements.txt, and removes it from the new requirements.txt it just generated. This is because assumes that the user means to uninstall pulp-container, which its countainerpart
pip-syncwould do - pulp_installer uses
pipcommands to perform the install/upgrade instead. (Pulp doesn't support uninstalling plugins, - The installer later fails with an import error due to pulp-container still being an old incompatible version.
Users can work around this currently by making sure to specify all installed plugins in pulp_install_plugins.
We need to fix this by adding any missing installed plugins, not found in pulp_install_plugins, to requirements.in. We need to normalize their names with dashes (pip / pypi converts underscores to dashes.) And we need to search for plugins named like "pulp-*", but we may make exceptions (for galaxy_ng.)
Actions
.
Problem: pre-flight check does not check plugins that are installed but not listed in pulp_install_plugins
Solution: List them in requirements.in Implementation includes:
fixes: #6644 pre-flight check does not check plugins that are installed but not listed in pulp_install_plugins https://pulp.plan.io/issues/6644
re: #6623 pulpcore and plugin pre-flight check seems to not be enforcing and then installer fails at collectstatic https://pulp.plan.io/issues/6623