Issue #652
closedTwo tracebacks are written to the log when syncs fail
Description
Description of problem:
If a sync fails with an Exception, that Exception's traceback is logged (good), and then an Exception like this is logged (bad):
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/celery/app/trace.py", line 240, in trace_task
R = retval = fun(*args, **kwargs)
File "/usr/lib/python2.6/site-packages/pulp/server/async/tasks.py", line 306, in call
return super(Task, self).__call__(*args, **kwargs)
File "/usr/lib/python2.6/site-packages/celery/app/trace.py", line 437, in protected_call
return self.run(*args, **kwargs)
File "/usr/lib/python2.6/site-packages/pulp/server/tasks/repository.py", line 210, in sync_with_auto_publish
sync_result = managers.repo_sync_manager().sync(repo_id, sync_config_override=overrides)
File "/usr/lib/python2.6/site-packages/pulp/server/managers/repo/sync.py", line 113, in sync
raise PulpExecutionException(_('Importer indicated a failed response'))
PulpExecutionException: Importer indicated a failed response
This traceback isn't useful, and sometimes users will give this to us instead of the real one since it appears "more recently" in the log.
Version-Release number of selected component (if applicable):
2.4.3-1
How reproducible:
Every time
Steps to Reproduce:
1. Edit some code to cause a traceback during a sync
2. Run the sync
Actual results:
You will see two tracebacks in the log, and the latter one is the uninformative one above.
Expected results:
You should see only one traceback in the log.
+ This bug was cloned from Bugzilla Bug #1178991 +
Related issues
Updated by amacdona@redhat.com almost 10 years ago
- Related to Issue #515: Bad return code upon failed repo sync added
Added by mhrivnak over 9 years ago
Added by mhrivnak over 9 years ago
Updated by mhrivnak over 9 years ago
- Status changed from NEW to POST
- Platform Release set to 2.7.0
Added by mhrivnak over 9 years ago
Revision 3f9c1e0a | View on GitHub
sync errors now use PulpCodedException for better error reporting
refs #652
Added by mhrivnak over 9 years ago
Added by mhrivnak over 9 years ago
Updated by dkliban@redhat.com over 9 years ago
- Status changed from MODIFIED to 5
Updated by amacdona@redhat.com about 9 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
Task failures of known types no longer log tracebacks.
This goes along with additional changes to plugins so they can take advantage of smarter error reporting. This includes the use of the unittest2 module for testing that error reporting.
refs #652 refs #702