Project

Profile

Help

Actions
Send by e-mail Copy link

Task #6342

closed

Move reusable parts of the AsciiArmoredDetachedSigningService into the parent class

Added by quba42 over 4 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
quba42
Category:
-
Sprint/Milestone:
3.3.0
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

While working on the AptReleaseSigningService for Debian (https://github.com/pulp/pulp_deb/pull/160)

I noticed that the only thing that really needs to be different for each siginig service is the verification of the external script.

As such, most of everything else can be moved into the SigningService parent class, to be reusable across different signing services.

I have started working on the refactor here: https://github.com/pulp/pulpcore/pull/584

Added by quba42 over 4 years ago

Revision ca1c9ee8 | View on GitHub

Refactor the existing SigningService classes

fixes #6342

https://pulp.plan.io/issues/6342

Actions
Copy link
 #1

Updated by quba42 over 4 years ago

  • Status changed from NEW to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #2

Updated by ttereshc over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
  • Sprint/Milestone set to 3.3.0
Actions
Send by e-mail Copy link

Also available in: Atom PDF