Project

Profile

Help

Task #6342

Move reusable parts of the AsciiArmoredDetachedSigningService into the parent class

Added by quba42 8 months ago. Updated 7 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:

Description

While working on the AptReleaseSigningService for Debian (https://github.com/pulp/pulp_deb/pull/160)

I noticed that the only thing that really needs to be different for each siginig service is the verification of the external script.

As such, most of everything else can be moved into the SigningService parent class, to be reusable across different signing services.

I have started working on the refactor here: https://github.com/pulp/pulpcore/pull/584

Associated revisions

Revision ca1c9ee8 View on GitHub
Added by quba42 7 months ago

Refactor the existing SigningService classes

fixes #6342

https://pulp.plan.io/issues/6342

History

#1 Updated by quba42 7 months ago

  • Status changed from NEW to MODIFIED
  • % Done changed from 0 to 100

#2 Updated by ttereshc 7 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
  • Sprint/Milestone set to 3.3.0

Please register to edit this issue

Also available in: Atom PDF