Project

Profile

Help

Issue #6243

closed

When pip_version_specifier is set to null, broken config is generated

Added by ttereshc about 4 years ago. Updated almost 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Plugin Template
Sprint:
Sprint 68
Quarter:

Description

One can specify a pip_version_specifier to point to a specific plugin release. There is also a pulpcore_pip_version_specifier which points to a specific pulpcore release.

On the master branch it makes sense to unset those and have them set only for releases.

Their behaviour is inconsistent when they are unset and might lead to a broken config. To use the latest PyPI release, one can set pulpcore_pip_version_specifier to 'null'. To use the latest PyPI release for plugins, one must remove it from the config, because setting it to 'null' will generate a broken config, it adds 'None' to the plugin name.

   - pulp-2to3-migration-${TAG}:
       image_name: pulp-2to3-migration
       tag: $TAG
-      pulpcore: pulpcore~=3.0.0
+      pulpcore: pulpcore
       plugins:
         - ./pulp-2to3-migration
-        - pulp_file~=0.1.0
-        - pulp_container~=1.0.0
+        - pulp_fileNone
+        - pulp_containerNone
+        - pulp_rpmNone

Added by Mike DePaulo about 4 years ago

Revision c2ac83c3 | View on GitHub

Problem: When pip_version_specifier is set to null, broken config is generated

solution: Pass "true" to the 2nd value of the default filters. Thus: null value -> evaluates to false -> defaults to omitting the string.

fixes: #6243

Actions #1

Updated by fao89 about 4 years ago

  • Status changed from NEW to POST
  • Assignee set to mdepaulo@redhat.com
  • Triaged changed from No to Yes
  • Sprint set to Sprint 67
Actions #2

Updated by rchan almost 4 years ago

  • Sprint changed from Sprint 67 to Sprint 68
Actions #3

Updated by Anonymous almost 4 years ago

  • Status changed from POST to MODIFIED
Actions #4

Updated by mdepaulo@redhat.com almost 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF