Actions
Task #5946
closed
Task #5944: [Epic] As a plugin writer, I can use a SigningService to produce ascii-armored signatures
Add sign_file(filename) interface to SigningService model
Start date:
Due date:
% Done:
100%
Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 65
Quarter:
Description
A plugin author should be able to use an instance of a SigningService to produce a signed Artifact from an Artifact.
SigningService needs to provide a method called 'sign_file(filename)'. This method always returns a dictionary where each key is a relative path inside the worker's working directory and the value is the sha256 sum of that file. E.g.:
{
"repomd.xml.asc": "ce72f1c9f90c6ca85a88352b677ed8cc85d4ba81b4887be39afb01ad9c4fd8f8",
"repomd.xml.gpg": "e36e08b23107745247855b1a06d6d8ae27883fb56d7d7a282d93393db801cfe0"
}
The following code[0] in pulp_rpm:
with open(repomd_path, "w") as repomd_f:
repomd_f.write(repomd.xml_dump())
PublishedMetadata.create_from_file(
relative_path=os.path.join(repodata_path, os.path.basename(repomd_path)),
publication=publication,
file=File(open(repomd_path, 'rb'))
)
Would look more like this:
signer = SigningService.objects.get(pk=blah)
with open(repomd_path, "w") as repomd_f:
repomd_f.write(repomd.xml_dump())
signed_files = signer.sign_file(repomd_path)
for file_path, sha256 in signed_files.items():
PublishedMetadata.create_from_file(
relative_path=os.path.join(repodata_path, os.path.basename(file_path)),
publication=publication,
file=File(open(file_path, 'rb'))
)
Actions
.