Project

Profile

Help

Refactor #5701

closed

Performance improvement in remote duplicates

Added by dalley almost 3 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 63
Quarter:

Description

The current implementation of the "Remove Duplicates" functionality is probably lacking in efficiency. It looks like this:

query_for_repo_duplicates_by_type = defaultdict(lambda: Q())
for item in repository_version.added():
    detail_item = item.cast()

    if detail_item.repo_key_fields == ():
        continue
    unit_q_dict = {
        field: getattr(detail_item, field) for field in detail_item.repo_key_fields
    }
    item_query = Q(**unit_q_dict) & ~Q(pk=detail_item.pk)
    query_for_repo_duplicates_by_type[detail_item._meta.model] |= item_query

for model in query_for_repo_duplicates_by_type:
    _logger.debug(_("Removing duplicates for type: {}".format(model)))
    qs = model.objects.filter(query_for_repo_duplicates_by_type[model])
    repository_version.remove_content(qs)

While I haven't measured the exact impact, the individual item.cast() for each item is probably quite expensive. What would likely improve the situation is one of the following:

Proposal 1:

  1. Sort these into groups based on their pulp_type which is present on the master Content model.
  2. Look up the detail content models that represent the pulp_type strings
  3. Query the detail content models directly, in bulk, provided a list of PKs, instead of cast() individually
  4. Then within each type group check for duplicates

Proposal 2:

Alternately, each repository can list all of the content types it supports, which would allow us to skip item 2 above (maybe item 1 also) and would allow us to provide an extra layer of protection around making sure you can't have e.g. file content in an RPM repository which we can't easily or centrally guarantee otherwise.


Related issues

Related to RPM Support - Issue #5688: Large memory consumption when syncing RHEL 7 os x86_64CLOSED - CURRENTRELEASEfao89Actions
Actions #1

Updated by dalley almost 3 years ago

  • Description updated (diff)
Actions #2

Updated by dalley almost 3 years ago

  • Tracker changed from Refactor to Issue
  • Severity set to 2. Medium
  • Triaged set to No
Actions #3

Updated by fao89 almost 3 years ago

  • Tracker changed from Issue to Refactor
  • % Done set to 0
Actions #4

Updated by fao89 almost 3 years ago

  • Related to Issue #5688: Large memory consumption when syncing RHEL 7 os x86_64 added
Actions #5

Updated by dalley almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley
Actions #7

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 62 to Sprint 63

Added by dalley almost 3 years ago

Revision 0604a7b4

Add additional content type verification to RepositoryVersion

re: #5701 https://pulp.plan.io/issues/5701

Added by dalley almost 3 years ago

Revision 1861257b

Improve performance of removing duplicates

closes: #5701 https://pulp.plan.io/issues/5701

Actions #8

Updated by dalley almost 3 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

Added by dalley almost 3 years ago

Revision f4f190c2

Add CONTENT_TYPES to repo definition

Required PR: https://github.com/pulp/pulpcore/pull/441

re: #5701 https://pulp.plan.io/issues/5701 (cherry picked from commit 140d849544fa2467ba30db16e6b5163274a4b3d0)

Added by dalley almost 3 years ago

Revision cc2fb46a

Add CONTENT_TYPES to repo definition

Required PR: https://github.com/pulp/pulpcore/pull/441

re: #5701 https://pulp.plan.io/issues/5701 (cherry picked from commit 3caded8c2e6a5d3be5be218713741e7e4ae515ed)

Added by dalley almost 3 years ago

Revision cc2fb46a

Add CONTENT_TYPES to repo definition

Required PR: https://github.com/pulp/pulpcore/pull/441

re: #5701 https://pulp.plan.io/issues/5701 (cherry picked from commit 3caded8c2e6a5d3be5be218713741e7e4ae515ed)

Added by dalley almost 3 years ago

Revision 6b2af564

Add additional content type verification to RepositoryVersion

re: #5701 https://pulp.plan.io/issues/5701 (cherry picked from commit 0604a7b41cc5c394b9769d13f31fd0744d6d0ca7)

Added by dalley almost 3 years ago

Revision 66dc8749

Improve performance of removing duplicates

closes: #5701 https://pulp.plan.io/issues/5701 (cherry picked from commit 1861257bee238b91488101c1ae257484fa48ab87)

Added by dalley almost 3 years ago

Revision 32c1d08f

Add CONTENT_TYPES to repo definition

Required PR: https://github.com/pulp/pulpcore/pull/441

re: #5701 https://pulp.plan.io/issues/5701 (cherry picked from commit fb3cda3c7314d0d7c5bb3e0c1e440808959be191)

Actions #9

Updated by bmbouter almost 3 years ago

  • Sprint/Milestone set to 3.0.0
Actions #10

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF