Project

Profile

Help

Issue #5560

PULP_SETTINGS environment variable does not work

Added by dkliban@redhat.com 6 months ago. Updated 4 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
Yes
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 60

Description

Settings file in /etc/pulp/settings.py is the only place where settings can be defined. Users used to be able to set PULP_SETTINGS environment variable to point to a different location.

Associated revisions

Revision df3b51b3 View on GitHub
Added by Mike DePaulo 6 months ago

Containers: Adds the PULP_SETTINGS Env Var

Please merge before PR: https://github.com/pulp/pulpcore/pull/342

re: #5560 PULP_SETTINGS environment variable does not work https://pulp.plan.io/issues/5560

[noissue]

Revision 6e3ad089 View on GitHub
Added by Mike DePaulo 6 months ago

Adds the PULP_SETTINGS Env Var

Sets it in:

  • systemd units
  • pulp-devel role bash script
  • Any task/handler that calls django-admin

https://pulp.plan.io/issues/5560 closes #5560

Revision 6e3ad089 View on GitHub
Added by Mike DePaulo 6 months ago

Adds the PULP_SETTINGS Env Var

Sets it in:

  • systemd units
  • pulp-devel role bash script
  • Any task/handler that calls django-admin

https://pulp.plan.io/issues/5560 closes #5560

Revision 513952bd View on GitHub
Added by bmbouter 6 months ago

Remove hard coded /etc/pulp/settings.py file

This changes Pulp to not assume any settings file is needed or looked for at all. It encourages the user to set one via the PULP_SETTINGS Environment Variable. The settings documentation was updated to reflect this.

The Installer will continue working as is. The PR below causes the installer to set PULP_SETTINGS correctly allowing settings to work the same way in those environments.

Required PR: https://github.com/pulp/ansible-pulp/pull/182

https://pulp.plan.io/issues/5560 closes #5560

Revision df2f3528 View on GitHub
Added by bmbouter 6 months ago

Set PULP_SETTINGS

pulpcore recently got a change where /etc/pulp/settings.py was no longer hard coded. This causes the installer to set that same path in various places.

https://pulp.plan.io/issues/5560 closes #5560

Revision 072b830e View on GitHub
Added by Mike DePaulo 6 months ago

Problem: CI with old plugin-template fails

due to PULP_SETTINGS being unset for multiple commands like django-admin.

Solution: Set PULP_SETTINGS in .travis.yml

re: #5560 PULP_SETTINGS environment variable does not work https://pulp.plan.io/issues/5560

[noissue]

History

#1 Updated by bmbouter 6 months ago

I think this would be simpler if we didn't expect settings in /etc/pulp/settings.py, but instead recommend users use PULP_SETTINGS itself. Users would get more capabilities by for instance being able to natively provide their settings with .toml instead.

The Ansible installer should continue to use /etc/pulp/settings.py, only it needs to also specify PULP_SETTINGS in its systemd files, along with the other environment vars it sets.

#4 Updated by bmbouter 6 months ago

I think we should make this a 3.0 blocker, and also treat this as a docs change mostly to undocument the /etc/pulp/settings.py expectation, and add the PULP_SETTINGS callout to specify that file.

#5 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0.0

#6 Updated by daviddavis 6 months ago

  • Groomed changed from No to Yes

#7 Updated by bmbouter 6 months ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bmbouter
  • Sprint set to Sprint 60

#8 Updated by fabricio.aguiar 6 months ago

  • Triaged changed from No to Yes

#10 Updated by Anonymous 6 months ago

  • Status changed from POST to MODIFIED

#11 Updated by bmbouter 6 months ago

  • Status changed from MODIFIED to POST

Bringing back to POST for one more PR to merge.

#12 Updated by bmbouter 6 months ago

  • Status changed from POST to MODIFIED

#13 Updated by bmbouter 6 months ago

  • Status changed from MODIFIED to POST

#14 Updated by bmbouter 6 months ago

  • Status changed from POST to MODIFIED

#15 Updated by bmbouter 4 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF