Task #5500: Specify plugin dependencies on plugin_template - Pulp

Actions

Send by e-mail Copy link

Task #5500

closed

Specify plugin dependencies on plugin_template

Added by fao89 about 5 years ago. Updated almost 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

Groomed:

Sprint Candidate:

Tags:

Plugin Template

Sprint:

Sprint 60

Quarter:

Description

Currently, plugin_template defaults to install only pulp-certguard as dependency
https://github.com/pulp/plugin_template/blob/master/templates/travis/.travis/install.sh.j2#L50-L69

We want to be able to specify other plugins as a dependency.

Actions

Copy link

Updated by fao89 about 5 years ago

For pulp-2to3-migration it was needed to add pulp_file as a dependency:

# For pulpcore, and any other repo that might check out a pulp-certguard PR
if [ -e $TRAVIS_BUILD_DIR/../pulp-certguard ]; then
  PULP_CERTGUARD=./pulp-certguard
else
  # Otherwise, master branch release
  PULP_CERTGUARD=git+https://github.com/pulp/pulp-certguard.git
fi

if [ -e $TRAVIS_BUILD_DIR/../pulp_file ]; then
  PULP_FILE=./pulp_file
else
  # Otherwise, master branch release
  PULP_FILE=git+https://github.com/pulp/pulp_file.git
fi

cat > vars/vars.yaml << VARSYAML
---
images:
  - ${PLUGIN}-${TAG}:
      image_name: $PLUGIN
      tag: $TAG
      pulpcore: ./pulpcore
      pulpcore_plugin: ./pulpcore-plugin
      plugins:
        - $PULP_CERTGUARD
        - $PULP_FILE
        - ./$PLUGIN
VARSYAML

https://github.com/pulp/pulp-2to3-migration/pull/22/files#diff-60f45dbdd96bd53a91fbbadd0b05b43aR59-R78

Actions

Copy link