Project

Profile

Help

Task #5500

closed

Specify plugin dependencies on plugin_template

Added by fao89 over 4 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Plugin Template
Sprint:
Sprint 60
Quarter:

Description

Currently, plugin_template defaults to install only pulp-certguard as dependency
https://github.com/pulp/plugin_template/blob/master/templates/travis/.travis/install.sh.j2#L50-L69

We want to be able to specify other plugins as a dependency.

Actions #1

Updated by fao89 over 4 years ago

For pulp-2to3-migration it was needed to add pulp_file as a dependency:

# For pulpcore, and any other repo that might check out a pulp-certguard PR
if [ -e $TRAVIS_BUILD_DIR/../pulp-certguard ]; then
  PULP_CERTGUARD=./pulp-certguard
else
  # Otherwise, master branch release
  PULP_CERTGUARD=git+https://github.com/pulp/pulp-certguard.git
fi

if [ -e $TRAVIS_BUILD_DIR/../pulp_file ]; then
  PULP_FILE=./pulp_file
else
  # Otherwise, master branch release
  PULP_FILE=git+https://github.com/pulp/pulp_file.git
fi

cat > vars/vars.yaml << VARSYAML
---
images:
  - ${PLUGIN}-${TAG}:
      image_name: $PLUGIN
      tag: $TAG
      pulpcore: ./pulpcore
      pulpcore_plugin: ./pulpcore-plugin
      plugins:
        - $PULP_CERTGUARD
        - $PULP_FILE
        - ./$PLUGIN
VARSYAML

https://github.com/pulp/pulp-2to3-migration/pull/22/files#diff-60f45dbdd96bd53a91fbbadd0b05b43aR59-R78

Actions #2

Updated by fao89 over 4 years ago

  • Tags Plugin Template added
Actions #3

Updated by fao89 over 4 years ago

  • Status changed from NEW to POST
  • Sprint set to Sprint 60

Added by Fabricio Aguiar over 4 years ago

Revision 193a63ab | View on GitHub

include additional plugins on travis

closes #5500 https://pulp.plan.io/issues/5500

Actions #4

Updated by Anonymous over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #5

Updated by bmbouter over 4 years ago

  • Sprint/Milestone set to 3.0.0
Actions #6

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF