Task #5428
closed
Story #5443: [Epic] Remove leading _ from pulpcore model fields
Rename the fields "_relative_path" and "_artifact" on the SingleArtifactContentSerializer to "relative_path" and "artifact" respectively
100%
Description
The content serializers provided by pulpcore-plugin are only convenience layers for the plugin writer. Their _artifact and _relative_path fields do not refer directly to filed on the corresponding content models, but are translated into ContentArtifacts on create. Plugins really exposing the relative_path field take some effort to rename it to relative_path in a way that might even skip some valuable validation.
There has been some consensus that those fields should be named artifact and relative_path.
Related issues
Added by mdellweg about 5 years ago
Updated by mdellweg about 5 years ago
- Status changed from NEW to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulpcore|342f4539c09a7accda7d2ffaaea7666b1dac0463.
Added by mdellweg about 5 years ago
Revision e2a6be76 | View on GitHub
Adjust FileContentSerializer to upstream change
Updated by daviddavis about 5 years ago
- Status changed from POST to MODIFIED
- Sprint/Milestone set to 71
Updated by daviddavis about 5 years ago
- Related to Issue #5445: "KeyError: 'relative_path'" in SingleArtifactContentSerializer added
Updated by bmbouter almost 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Rename ContentSerializer fields
fixes #5428 https://pulp.plan.io/issues/5428
Required PR: https://github.com/pulp/pulp_file/pull/273 Required PR: https://github.com/PulpQE/pulp-smash/pull/1219