Project

Profile

Help

Task #5428

Story #5443: [Epic] Remove leading _ from pulpcore model fields

Rename the fields "_relative_path" and "_artifact" on the SingleArtifactContentSerializer to "relative_path" and "artifact" respectively

Added by mdellweg 7 months ago. Updated 4 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:

Description

The content serializers provided by pulpcore-plugin are only convenience layers for the plugin writer. Their _artifact and _relative_path fields do not refer directly to filed on the corresponding content models, but are translated into ContentArtifacts on create. Plugins really exposing the relative_path field take some effort to rename it to relative_path in a way that might even skip some valuable validation.

There has been some consensus that those fields should be named artifact and relative_path.


Related issues

Related to Pulp - Issue #5445: "KeyError: 'relative_path'" in SingleArtifactContentSerializer CLOSED - CURRENTRELEASE Actions

Associated revisions

Revision e2a6be76 View on GitHub
Added by mdellweg 7 months ago

Adjust FileContentSerializer to upstream change

re #5428 https://pulp.plan.io/issues/5428

History

#1 Updated by mdellweg 7 months ago

  • Assignee set to mdellweg

#2 Updated by mdellweg 7 months ago

  • Status changed from NEW to MODIFIED
  • % Done changed from 0 to 100

#3 Updated by daviddavis 7 months ago

  • Status changed from MODIFIED to POST

#4 Updated by daviddavis 7 months ago

  • Status changed from POST to MODIFIED
  • Sprint/Milestone set to 71

#5 Updated by dkliban@redhat.com 7 months ago

  • Parent task set to #5443

#6 Updated by daviddavis 7 months ago

  • Related to Issue #5445: "KeyError: 'relative_path'" in SingleArtifactContentSerializer added

#7 Updated by bmbouter 7 months ago

  • Sprint/Milestone changed from 71 to 3.0.0

#8 Updated by bmbouter 4 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF