Actions
Story #5422
closed
As a user Galaxy V3 user, I can submit expected_namespace, expected_name, expected_version and if the metadata doesn't match it fails
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:
100%
Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Sprint:
Sprint 58
Quarter:
Description
Problem¶
There is a use case where the user is Galaxy and submitting data it received from a user it does not trust. The problem is that the actual metadata isn't known until the tarball is extracted, but by then regardless of what it is, it's imported and live.
Solution¶
Have the Galaxy v3/artifacts/collections/ endpoint take 3 optional arguments: 'expected_namespace', 'expected_name', 'expected_version'. If set, validate that the uploaded Collection is asserting these values.
If they do not match, fail the import task and delete the Artifact since it was not appropriate to be saved.
Updated by bmbouter over 5 years ago
- Subject changed from As a user Galaxy V3 user, I can submit expected_namespace, expected_name, expected_version and if the metadata doisn't match it fails to As a user Galaxy V3 user, I can submit expected_namespace, expected_name, expected_version and if the metadata doesn't match it fails
- Description updated (diff)
Updated by bmbouter over 5 years ago
- Status changed from NEW to POST
PR available at: https://github.com/pulp/pulp_ansible/pull/196/
Updated by daviddavis over 5 years ago
- Groomed changed from No to Yes
- Sprint set to Sprint 58
Added by bmbouter over 5 years ago
Updated by bmbouter over 5 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp_ansible|b2342c0412116c2a120f27e9d16ab70853f12c28.
Updated by bmbouter about 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
.
Add CollectionImport log handler and Validation
Add add_log_message() facility to the CollectionImport model. This is called by the log handler which is auto-configured by pulp_ansible with this commit.
The logger is 'pulp_ansible.app.tasks.collection.import_collection'.
Add validation feature to CollectionImport where the
expected_namespace,expected_name, andexpected_versionare specified. When used the import will fail if the tarball does not contain the same values. These are optional parameters and only available in the Galaxy V3 API currently.https://pulp.plan.io/issues/5366 closes #5366
https://pulp.plan.io/issues/5422 closes #5422