Story #5413: As a plugin writer, declarative artifacts without a "remote" will not have RemoteArtifacts created - Pulp

Actions

Send by e-mail Copy link

Story #5413

closed

As a plugin writer, declarative artifacts without a "remote" will not have RemoteArtifacts created

Added by ppicka over 5 years ago. Updated about 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dkliban@redhat.com

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

Groomed:

Yes

Sprint Candidate:

Tags:

Sprint:

Sprint 59

Quarter:

Description

If a plugin writer does not declarate a "remote" on a declarative Artifact have no RemoteArtifact objects be created.

Validation adjustments¶

The validation there will need to be loosened to allow remote to be unset. When unset, the Artifact must already have it's binary data attached to the in-memory Artifact causing ArtifactDownloader to pass it through unmodified.

The Artifact can be saved or unsaved. If saved the ArtifactSaver stage will effectively pass it through unmodified. If unsaved the ArtifactSaver stage will perform its usual operation.

Useful for example in modularity support when we got artifact from first stage which doesn't need to be downloaded but should go through stage to create right relations with content.

Actions

Copy link

Updated by bmbouter over 5 years ago

Subject changed from Possibility to skip artifact download and remote artifact saver stages at Sync to As a plugin writer, declarative artifacts without a "remote" will not have RemoteArtifacts created
Description updated (diff)

This doesn't have an affect on the ArtifactDownload or ArtifactSaver stages so I edited it to remove that part. ppicka does this sound right?

Actions

Copy link

Updated by bmbouter over 5 years ago

Description updated (diff)

Actions

Copy link

Updated by bmbouter over 5 years ago

I can see value in the created in-memory Artifact being unsaved because then the ArtifactSaver can efficiently save them in batches.

Regarding the ArtifactDownloader I don't think we need explicit skipping, as much as the current behavior should recognize the Artifact as already downloaded. So in that way it would be "skipped" with the existing logic.

Actions

Copy link