Project

Profile

Help

Issue #5321

closed

Stop having the installer call makemigrations (scheduled to merge Sept 3rd)

Added by daviddavis over 3 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Katello
Sprint:
Sprint 58
Quarter:

Description

In pulp_rpm, some PRs have failed to include migration changes. This problem has been masked by the fact that the installer calls makemigrations[0].

I think most (or all?) plugins have migrations in source control. If a plugin chooses not to check their migrations in, they can create a custom ansible prereq role to call makemigrations.

*Note: This is a breaking change and was announced on pulp-dev here This was communicated to be announced Sept 3rd.

[0] https://github.com/pulp/ansible-pulp/blob/3ade5515d486ff6b688476fd17f1557aec4a06f0/roles/pulp-database/tasks/main.yml#L46-L50


Related issues

Has duplicate Pulp - Issue #5361: Installer can fail if run a second time on a system due to the installer producing migrationsCLOSED - DUPLICATEActions
Actions #1

Updated by daviddavis over 3 years ago

  • Tags Pulp 3 installer added
Actions #2

Updated by daviddavis over 3 years ago

  • Description updated (diff)
Actions #3

Updated by amacdona@redhat.com over 3 years ago

+1, the time has come that this causes more trouble than it helps.

For whoever picks up this story, it would be very nice to put some thought and docs into how the migrations would be made for a new plugin. Specifically, I think it would be pretty unfriendly if a new plugin author needed to write an ansible role as a first step.

Actions #4

Updated by daviddavis over 3 years ago

  • Description updated (diff)
Actions #5

Updated by amacdona@redhat.com over 3 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 57
Actions #6

Updated by rchan over 3 years ago

  • Sprint changed from Sprint 57 to Sprint 58
Actions #7

Updated by amacdona@redhat.com over 3 years ago

  • Has duplicate Issue #5361: Installer can fail if run a second time on a system due to the installer producing migrations added
Actions #8

Updated by bmbouter over 3 years ago

  • Subject changed from Stop having the installer call makemigrations to Stop having the installer call makemigrations (scheduled to merge Sept 3rd)
  • Description updated (diff)
Actions #9

Updated by bmbouter over 3 years ago

  • Tags Katello-P2 added
  • Tags deleted (Pulp 3 installer)

Adding in the P2 as reported on the duplicate.

Actions #10

Updated by daviddavis over 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

Added by daviddavis over 3 years ago

Revision 934257f4

Remove steps to generate migrations

refs #5321

Added by daviddavis over 3 years ago

Revision 934257f4

Remove steps to generate migrations

refs #5321

Actions #12

Updated by daviddavis over 3 years ago

Note that we should also remove app_label as part of this work since it's used for generating migrations.

Added by daviddavis over 3 years ago

Revision e94c4356

Remove app_label variable since it's unused

fixes #5321

Added by daviddavis over 3 years ago

Revision e94c4356

Remove app_label variable since it's unused

fixes #5321

Added by Mike DePaulo over 3 years ago

Revision e7148464

Remove steps to generate migrations

re: #5321

[noissue]

Actions #13

Updated by daviddavis over 3 years ago

  • Status changed from ASSIGNED to MODIFIED

Added by Mike DePaulo about 3 years ago

Revision 8f9f3f4c

Remove app_label variable since it's unused

re: #5321

[noissue]

Actions #14

Updated by bmbouter almost 3 years ago

  • Sprint/Milestone set to 3.0.0
Actions #15

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #16

Updated by ggainey over 2 years ago

  • Tags Katello added
  • Tags deleted (Katello-P2)

Also available in: Atom PDF