Issue #5321
closed
Stop having the installer call makemigrations (scheduled to merge Sept 3rd)
Description
In pulp_rpm, some PRs have failed to include migration changes. This problem has been masked by the fact that the installer calls makemigrations[0].
I think most (or all?) plugins have migrations in source control. If a plugin chooses not to check their migrations in, they can create a custom ansible prereq role to call makemigrations.
*Note: This is a breaking change and was announced on pulp-dev here This was communicated to be announced Sept 3rd.
Related issues
Updated by amacdona@redhat.com about 5 years ago
+1, the time has come that this causes more trouble than it helps.
For whoever picks up this story, it would be very nice to put some thought and docs into how the migrations would be made for a new plugin. Specifically, I think it would be pretty unfriendly if a new plugin author needed to write an ansible role as a first step.
Updated by amacdona@redhat.com about 5 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 57
Updated by amacdona@redhat.com about 5 years ago
- Has duplicate Issue #5361: Installer can fail if run a second time on a system due to the installer producing migrations added
Updated by bmbouter about 5 years ago
- Subject changed from Stop having the installer call makemigrations to Stop having the installer call makemigrations (scheduled to merge Sept 3rd)
- Description updated (diff)
Updated by bmbouter about 5 years ago
- Tags Katello-P2 added
- Tags deleted (
Pulp 3 installer)
Adding in the P2 as reported on the duplicate.
Updated by daviddavis about 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Added by daviddavis about 5 years ago
Added by daviddavis about 5 years ago
Revision 934257f4 | View on GitHub
Remove steps to generate migrations
refs #5321
Updated by daviddavis about 5 years ago
ansible-pulp change: https://github.com/pulp/ansible-pulp/pull/144
Updated by daviddavis about 5 years ago
Note that we should also remove app_label as part of this work since it's used for generating migrations.
Added by daviddavis about 5 years ago
Revision e94c4356 | View on GitHub
Remove app_label variable since it's unused
fixes #5321
Added by daviddavis about 5 years ago
Revision e94c4356 | View on GitHub
Remove app_label variable since it's unused
fixes #5321
Added by Mike DePaulo about 5 years ago
Updated by daviddavis about 5 years ago
- Status changed from ASSIGNED to MODIFIED
Applied in changeset ansible-pulp3|e94c435624e605e9a01018a61e97c6f02afd49f8.
Added by Mike DePaulo about 5 years ago
Updated by bmbouter almost 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Updated by ggainey over 4 years ago
- Tags Katello added
- Tags deleted (
Katello-P2)
.
Remove steps to generate migrations
refs #5321