Issue #5321: Stop having the installer call makemigrations (scheduled to merge Sept 3rd) - Pulp

Actions

Send by e-mail Copy link

Issue #5321

closed

Stop having the installer call makemigrations (scheduled to merge Sept 3rd)

Added by daviddavis over 4 years ago. Updated almost 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

daviddavis

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Katello

Sprint:

Sprint 58

Quarter:

Description

In pulp_rpm, some PRs have failed to include migration changes. This problem has been masked by the fact that the installer calls makemigrations[0].

I think most (or all?) plugins have migrations in source control. If a plugin chooses not to check their migrations in, they can create a custom ansible prereq role to call makemigrations.

*Note: This is a breaking change and was announced on pulp-dev here This was communicated to be announced Sept 3rd.

[0] https://github.com/pulp/ansible-pulp/blob/3ade5515d486ff6b688476fd17f1557aec4a06f0/roles/pulp-database/tasks/main.yml#L46-L50

Related issues

Actions

Copy link

Updated by daviddavis over 4 years ago

Tags Pulp 3 installer added

Actions

Copy link

Updated by daviddavis over 4 years ago

Description updated (diff)

Actions

Copy link

Updated by amacdona@redhat.com over 4 years ago

+1, the time has come that this causes more trouble than it helps.

For whoever picks up this story, it would be very nice to put some thought and docs into how the migrations would be made for a new plugin. Specifically, I think it would be pretty unfriendly if a new plugin author needed to write an ansible role as a first step.

Actions

Copy link

Updated by daviddavis over 4 years ago

Description updated (diff)

Actions

Copy link

Updated by amacdona@redhat.com over 4 years ago

Triaged changed from No to Yes
Sprint set to Sprint 57

Actions

Copy link

Updated by rchan over 4 years ago

Sprint changed from Sprint 57 to Sprint 58

Actions

Copy link

Updated by amacdona@redhat.com over 4 years ago

Has duplicate Issue #5361: Installer can fail if run a second time on a system due to the installer producing migrations added

Actions

Copy link

Updated by bmbouter over 4 years ago

Subject changed from Stop having the installer call makemigrations to Stop having the installer call makemigrations (scheduled to merge Sept 3rd)
Description updated (diff)

Actions

Copy link