Project

Profile

Help

Issue #5308

closed

pulp can't handle update version as a string in updateinfo.xml

Added by dkliban@redhat.com almost 3 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.20.0
Platform Release:
2.21.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 58
Quarter:

Description

Pulp 2.13 could handle an updateinfo.xml like this will work

<updates>
  <update from="--------------@phoenixspa.it" status="stable" type="security" version="1-25">
    <id>FCSA:2017-0001</id>
    <title>Security Update for fc-proftpd-chroot</title>
    <release>PROFTPD-CHROOT</release>

However, this doesn't work in 2.20 as pulp is expecting the version to be a number.


Aug 01 11:53:54 example.com pulp[79521]: pulp_rpm.plugins.importers.yum.sync:ERROR: [7f2355a3] (79521-55712)     if not existing_erratum or existing_erratum.update_needed(new_erratum):
Aug 01 11:53:54 example.com pulp[79521]: pulp_rpm.plugins.importers.yum.sync:ERROR: [7f2355a3] (79521-55712)   File "/usr/lib/python2.7/site-packages/pulp_rpm/plugins/db/models.py", line 1253, in update_needed
Aug 01 11:53:54 example.com pulp[79521]: pulp_rpm.plugins.importers.yum.sync:ERROR: [7f2355a3] (79521-55712)     return util.is_version_newer(other.version, self.version)
Aug 01 11:53:54 example.com pulp[79521]: pulp_rpm.plugins.importers.yum.sync:ERROR: [7f2355a3] (79521-55712)   File "/usr/lib/python2.7/site-packages/pulp_rpm/yum_plugin/util.py", line 208, in is_version_newer
Aug 01 11:53:54 example.com pulp[79521]: pulp_rpm.plugins.importers.yum.sync:ERROR: [7f2355a3] (79521-55712)     new = float(new_version)
Aug 01 11:53:54 example.com pulp[79521]: pulp_rpm.plugins.importers.yum.sync:ERROR: [7f2355a3] (79521-55712) ValueError: invalid literal for float(): 1-25
Actions #2

Updated by amacdona@redhat.com almost 3 years ago

  • Project changed from Pulp to RPM Support
  • Triaged changed from No to Yes
  • Sprint set to Sprint 57
Actions #3

Updated by rchan almost 3 years ago

  • Sprint changed from Sprint 57 to Sprint 58
Actions #4

Updated by dkliban@redhat.com almost 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ggainey
Actions #5

Updated by ggainey over 2 years ago

  • Status changed from ASSIGNED to POST
  • Tags Pulp 2 added

Added by ggainey over 2 years ago

Revision 285e8c77

Respond to non-numeric versions by always assuming 'newer'

closes #5308 https://pulp.plan.io/issues/5308

Actions #6

Updated by ggainey over 2 years ago

  • Status changed from POST to MODIFIED
Actions #7

Updated by dalley over 2 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
  • Platform Release set to 2.21.0

Also available in: Atom PDF