Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #5012

closed

ssl_client_key printed in the logs

Added by dkliban@redhat.com almost 5 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
amacdona@redhat.com
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 57
Quarter:

Description

I noticed that when I performa PATCH request to update a FIle Remote, the ssl_client_key is printed in the logs at INFO level.

Actions
Copy link
 #1

Updated by amacdona@redhat.com almost 5 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 55
Actions
Copy link
 #2

Updated by dkliban@redhat.com almost 5 years ago

  • Sprint changed from Sprint 55 to Sprint 56
Actions
Copy link
 #3

Updated by rchan over 4 years ago

  • Sprint changed from Sprint 56 to Sprint 57
Actions
Copy link
 #4

Updated by amacdona@redhat.com over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to amacdona@redhat.com

Added by amacdona@redhat.com over 4 years ago

Revision a6fd4fbd | View on GitHub

Prevent rq from logging secrets

Though the issue is specific about certain cases that shouldn't be logged, we do not have fine control over what rq logs, so the solution is to disable logging of the description (which includes the job arguments).

https://pulp.plan.io/issues/5012 fixes #5012

Actions
Copy link
 #5

Updated by amacdona@redhat.com over 4 years ago

  • Status changed from ASSIGNED to MODIFIED
Actions
Copy link
 #6

Updated by amacdona@redhat.com over 4 years ago

  • Status changed from MODIFIED to POST

Added by amacdona@redhat.com over 4 years ago

Revision a1838b13 | View on GitHub

Prevent rq from logging secrets

Though the issue is specific about certain cases that shouldn't be logged, we do not have fine control over what rq logs, so the solution is to disable logging of the description (which includes the job arguments).

https://pulp.plan.io/issues/5012 fixes #5012

Added by amacdona@redhat.com over 4 years ago

Revision a1838b13 | View on GitHub

Prevent rq from logging secrets

Though the issue is specific about certain cases that shouldn't be logged, we do not have fine control over what rq logs, so the solution is to disable logging of the description (which includes the job arguments).

https://pulp.plan.io/issues/5012 fixes #5012

Actions
Copy link
 #7

Updated by amacdona@redhat.com over 4 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #8

Updated by bmbouter over 4 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #9

Updated by bmbouter over 4 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF