Issue #5009
closedHTML in our json api schema
Description
I noticed some strange descriptions for actions in our api schema when viewing it as json. I'm hitting the /pulp/api/v3/docs/api.json endpoint and seeing:
<!-- User-facing documentation, rendered as html-->\nFileRemote represents an external source of <a href=\"#operation/content_file_files_list\">File\nContent</a>. The target url of a FileRemote must contain a file manifest, which contains the\nmetadata for all files at the source.
I wonder if we should avoid including html in fields as our api schema since it can be rendered in many different forms (e.g. json).
I see a few downsides to having HTML in our api schema:
1. This forces me and pulp users like me who prefer to less
our api json docs to now use the generated html docs instead. I prefer to stick to the command line whenever possible.
2. Tools may eventually read/display these descriptions. I am thinking of potential tools like a pulp cli, tools that generate stuff like bash scripts or ansible roles, etc.
3. Other tools that can generate HTML like a Pulp web UI may not be able to properly generate this html. Stuff like links may not work properly.
Updated by dkliban@redhat.com over 5 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 55
We will add a query argument call 'include_html' which will cause the OpenAPI schema to be returned with HTML tags. If this argument is not included i nthe request to /pulp/api/v3/docs/api.json, the HTML is not included.
Updated by dkliban@redhat.com over 5 years ago
- Sprint changed from Sprint 55 to Sprint 56
Updated by daviddavis over 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Added by daviddavis over 5 years ago
Updated by daviddavis over 5 years ago
- Status changed from ASSIGNED to POST
Added by daviddavis over 5 years ago
Revision d615f23a | View on GitHub
Filter out html by default in REST API docs
Updated by daviddavis over 5 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulpcore|d615f23a0f59caf6c49e20cfa427d7d5e97ab4c5.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Add include_html flag to generation of plugin REST API docs
ref #5009 https://pulp.plan.io/issues/5009