Issue #4924: KeyError during migration 0004 - Debian Support - Pulp

Actions

Send by e-mail Copy link

Issue #4924

closed

KeyError during migration 0004

Added by quba42 over 5 years ago. Updated over 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Urgent

Assignee:

quba42

Sprint/Milestone:

Pulp - 2.20.0

Start date:

Due date:

Estimated time:

Severity:

4. Urgent

Version - Debian:

master

Platform Release:

2.20.0

Target Release - Debian:

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Pulp 2

Sprint:

Quarter:

Description

When there are importers with an empty "config" dict, migration 0004 will throw a KeyError

Applying migration pulp_deb.plugins.migrations.0004_add_distribution failed.

Halting migrations due to a migration failure.
'releases'
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/pulp/server/db/manage.py", line 279, in main
    return _auto_manage_db(options)
  File "/usr/lib/python2.7/site-packages/pulp/server/db/manage.py", line 346, in _auto_manage_db
    migrate_database(options)
  File "/usr/lib/python2.7/site-packages/pulp/server/db/manage.py", line 175, in migrate_database
    update_current_version=not options.test)
  File "/usr/lib/python2.7/site-packages/pulp/server/db/migrate/models.py", line 206, in apply_migration
    migration.migrate()
  File "/usr/lib/python2.7/site-packages/pulp_deb/plugins/migrations/0004_add_distribution.py", line 74, in migrate
    distributions = repo_importer['config']['releases'].split(',')
KeyError: 'releases'

Related issues

Actions

Copy link

Updated by quba42 over 5 years ago

The following PR should fix this: https://github.com/pulp/pulp_deb/pull/92

I have also had another look through the migration whether there are any other unguarded accesses to non required db fields (and I did not find any).

Actions

Copy link

Updated by quba42 over 5 years ago

Related to Issue #4138: Handling publish paths correctly added

Actions

Copy link

Updated by mdellweg over 5 years ago

Priority changed from Normal to Urgent
Triaged changed from No to Yes

Added by quba42 over 5 years ago

Revision 99bcc977 | View on GitHub

Fix migration 0004 for importers with empty config

This fix prevents KeyErrors during migration 0004. These can happen when there are importers with empty "config" dict.

In addition, the release['suite'] access has now also been guarded. All field access have been double checked to make sure they are sufficiently guarded.

fixes #4924 https://pulp.plan.io/issues/4924

Actions

Copy link