Story #4898: As a user, no "duplicated" content is present in a repo version - RPM Support - Pulp

Actions

Send by e-mail Copy link

Story #4898

closed

As a user, no "duplicated" content is present in a repo version

Added by ttereshc over 5 years ago. Updated over 4 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

ttereshc

Sprint/Milestone:

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

Groomed:

Sprint Candidate:

Tags:

Sprint:

Quarter:

Description

"Duplicates" are two pieces of content which are not allowed to exist within a single repo version.

E.g.

RPMs with the same nevra but different checksum types can't be in a single repo
Advisories with the same id can't be in one repo
Only one modulemd_defaults per module (name) can be in a single repo

There is a way to prevent that at sync time with RemoveDuplicates stage.
Currently there is no mechanism to prevent it if content is already in Pulp and user copies/adds content to a repo version.

Todos¶

add repo_key to RPMs for its NEVRA (but not checksum)
modulemd_default object gets a repo_key
remove the RemoveDuplicates stage from the pulp_rpm custom pipeline

Related issues

Actions

Copy link

Updated by ttereshc over 5 years ago

Description updated (diff)

Actions

Copy link

Updated by ttereshc over 5 years ago

Related to Story #5008: As a user, I can enforce content specific uniqueness constaints in a repo version added

Actions

Copy link

Updated by ttereshc about 5 years ago

Tags Pulp 3 RPM blocker added

Actions

Copy link

Updated by daviddavis about 5 years ago

Related to Story #5084: As a user, after copy or repo version creation there are no advisories with the same id added

Actions

Copy link

Updated by bmbouter about 5 years ago

If we add repo_key to each of the content units, would we still need the RemoteDuplicates stage?

Actions

Copy link

Updated by ttereshc about 5 years ago

I don't think we need RemoveDuplicates at all. Should we remove it from the Plugin API? I haven't seen your implementation of repo_key yet but the discussions in the past gave me an impression that it will fully substitute RemoveDuplicates stage.

We can't add a repo_key for Advisories though because we need to merge them. So Advisories will wait for a mechanism we are discussing on the pulp-dev now where a plugin can influence which content is added to a repo version creation.

Actions

Copy link

Updated by bmbouter about 5 years ago

Description updated (diff)

ttereshc wrote:

I don't think we need RemoveDuplicates at all. Should we remove it from the Plugin API? I haven't seen your implementation of repo_key yet but the discussions in the past gave me an impression that it will fully substitute RemoveDuplicates stage.

I agree. This ticket should include removing the RemoveDuplicates stage. I updated a todos section in the body.

We can't add a repo_key for Advisories though because we need to merge them. So Advisories will wait for a mechanism we are discussing on the pulp-dev now where a plugin can influence which content is added to a repo version creation.

I see what you're saying about this being related. I'll reply on that thread some.

Is the Advisory merging unhandled during sync today? I was looking in pulp_rpm and I see it only handles Package and RepoMetadataFile , so repo_key can fully replace RemoveDuplicates stage. Does that sound right to you?

Actions

Copy link