Issue #4397: Unable to sync 3 SLES Update repositories - RPM Support - Pulp

Actions

Send by e-mail Copy link

Issue #4397

closed

Unable to sync 3 SLES Update repositories

Added by daviddavis almost 6 years ago. Updated over 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

daviddavis

Sprint/Milestone:

Pulp - 2.19.0

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version:

Platform Release:

2.19.0

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Pulp 2

Sprint:

Sprint 48

Quarter:

Description

Filtering by srpm:

pulp-admin rpm repo create --repo-id testrepo --feed file:///home/vagrant/testrepo/ --skip srpm
pulp-admin rpm repo sync run --force-full --repo-id testrepo

Causes the following error:

Malformed repository: metadata is missing for some packages in filelists.xml and in other.xml

While syncing without the srpm filter seems to work fine.

Files

dupe_srpm_repodata.tgz (1.22 MB) dupe_srpm_repodata.tgz

daviddavis, 02/08/2019 03:29 PM

Related issues

Actions

Copy link

Updated by daviddavis almost 6 years ago

I noticed in the code that two different package counts are being returned for filtering by srpm[0] vs not filtering by srpm[1] and it looks like there's an extra check for the latter: it checks that serialized_version is not in versions. Thus, duplicate srpms are being counted when skipping srpms as opposed to when srpms are not being skipped, the code checks for dupes and thus arrives at a different package count.

[0] https://github.com/pulp/pulp_rpm/blob/aef3d5d1feb1a1ea10cd239f5bbe7a98c997922f/plugins/pulp_rpm/plugins/importers/yum/sync.py#L1072-L1074
[1] https://github.com/pulp/pulp_rpm/blob/aef3d5d1feb1a1ea10cd239f5bbe7a98c997922f/plugins/pulp_rpm/plugins/importers/yum/sync.py#L1080-L1081

Actions

Copy link

Updated by daviddavis almost 6 years ago

Project changed from Pulp to RPM Support

Actions

Copy link

Updated by daviddavis almost 6 years ago

File dupe_srpm_repodata.tgz dupe_srpm_repodata.tgz added
Status changed from NEW to ASSIGNED
Assignee set to daviddavis

Actions

Copy link

Updated by daviddavis almost 6 years ago

Adding the minimal set of repodata needed to reproduce this problem.

Added by daviddavis almost 6 years ago

Revision eceb27c6 | View on GitHub

Account for duplicate srpms in count when skipping srpms

The issue involved counting duplicate srpms when creating the package count for primary.xml which led the check against filelists.xml to fail. To create a unique package count, we're storing srpms we've seen thereby not counting them if we've seen the NEVRA already.

fixes #4397 https://pulp.plan.io/issues/4397

Actions

Copy link