Issue #4288
closed
_mysql_exceptions.OperationalError: (1170, "BLOB/TEXT column 'name' used in key specification without a key length")
Description
MySQL doesn't allow you to create an index on a text field unless you specify the length of the index (e.g. KEY pulp_app_workers_name (name(1000)). This is to prevent indexes from growing too large. We probably don't want to remove the key in which case we should either change the text fields to char fields or manually create the indexes in the db ourselves.
Here's how to search for the fields affected:
grep -r "TextField(db_index" *.py
Related issues
Updated by daviddavis about 6 years ago
- Blocks Task #4270: Add support for MariaDB and MySQL added
Updated by daviddavis almost 6 years ago
There are 5 instances in Pulp where we have TextFields with db indexes. They're all name fields. I noticed in some cases (e.g. ContentGuard, Distribution) we are using CharField. So to reiterate, the options are:
1. Change all names to use CharField and thus avoiding having to write raw SQL in our migrations
2. Write a migration with some raw sql to create the key with a length. I am not sure how db agnostic this is though.
Updated by daviddavis almost 6 years ago
- Blocks Task #4290: Investigate performance of Pulp with UUID PKs added
Updated by ttereshc almost 6 years ago
+1 to option 1, CharField.
In my opinion, we don't have a real need for TextField for names. And it seems that it's easier to stay DB-agnostic with a CharField and for some DBs it will also mean a performance gain (not for PostgreSQL though, it doesn't matter for it, AFAIK)
Updated by dkliban@redhat.com almost 6 years ago
we should go with the CharField
Updated by daviddavis almost 6 years ago
- Status changed from NEW to POST
- Assignee set to daviddavis
Added by daviddavis almost 6 years ago
Added by daviddavis almost 6 years ago
Revision ed49af03 | View on GitHub
MySQL doesn't support text fields as indexes
Changing fields from text to char since MySQL doesn't support text fields as indexes. Also, recreating the migrations since they blow up when you run them on MySQL.
Updated by daviddavis almost 6 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|ed49af030fcd78fb1d20aedd157b64951801d1ce.
Updated by daviddavis almost 6 years ago
- Status changed from MODIFIED to ASSIGNED
Updated by daviddavis almost 6 years ago
- Status changed from ASSIGNED to MODIFIED
Updated by daviddavis almost 6 years ago
- Status changed from MODIFIED to ASSIGNED
Updated by daviddavis almost 6 years ago
- Status changed from ASSIGNED to MODIFIED
Updated by dalley almost 6 years ago
- Blocks deleted (Task #4290: Investigate performance of Pulp with UUID PKs)
Updated by daviddavis almost 6 years ago
- Status changed from MODIFIED to POST
Additional pulp_file PR:
Added by daviddavis almost 6 years ago
Revision c0ff733e | View on GitHub
Changing relative_path and digest to CharFields
The relative_path and digest fields are text fields and are part of a unique constraint which MySQL/mariadb doesn't support.
Updated by bmbouter about 5 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
MySQL doesn't support text fields as indexes
Changing fields from text to char since MySQL doesn't support text fields as indexes. Also, recreating the migrations since they blow up when you run them on MySQL.
fixes #4288 https://pulp.plan.io/issues/4288