Project

Profile

Help

Refactor #4117

Refactor bulk_create calls in RpmContentUnitSaver

Added by bmbouter about 2 years ago. Updated 12 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 55
Quarter:

Description

The implementation of RpmContentUnitSaver needs to not rely on attaching attributes to models and then reading those attributes back later. For background see comments around this one: https://pulp.plan.io/issues/4060#note-12

That is currently done in the rpm code here: https://github.com/pulp/pulp_rpm/blob/844336c1c55427851861491a50746c1c2af48d4e/pulp_rpm/app/tasks/synchronizing.py#L293-L327

Associated revisions

Revision 6f58b19b View on GitHub
Added by ttereshc over 1 year ago

Stop using model attributes to carry related models to save later

Use extra_data attribute of DeclarativeContent instead.

closes #4117 https://pulp.plan.io/issues/4117

History

#1 Updated by bmbouter about 2 years ago

  • Tracker changed from Issue to Refactor
  • Subject changed from Rework bulk_create calls in ErratumContentUnitSaver to Refactor bulk_create calls in ErratumContentUnitSaver
  • % Done set to 0

#2 Updated by bmbouter about 2 years ago

We could use a zip() style which relies on the bulk_create order of items in and items out being the same. dalley confirmed in #django that it's implementation does preserve order today. Here is an example: https://github.com/pulp/pulp/compare/master...dralley:single-table-content?expand=1#diff-724178b047dc8948469adbef5243c6c0R126

#3 Updated by ttereshc over 1 year ago

  • Subject changed from Refactor bulk_create calls in ErratumContentUnitSaver to Refactor bulk_create calls in RpmContentUnitSaver
  • Description updated (diff)
  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

#4 Updated by ttereshc over 1 year ago

  • Sprint set to Sprint 50

#5 Updated by dalley over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley

#6 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 50 to Sprint 51

#7 Updated by daviddavis over 1 year ago

  • Sprint changed from Sprint 51 to Sprint 52

#8 Updated by bmbouter over 1 year ago

  • Tags deleted (Pulp 3)

#9 Updated by dalley over 1 year ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (dalley)

Working on higher priority items currently - anyone else can pick this up. I never got very far on my branch.

#10 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 52 to Sprint 53

#11 Updated by amacdona@redhat.com over 1 year ago

  • Sprint changed from Sprint 53 to Sprint 54

#12 Updated by ttereshc over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc

#13 Updated by ttereshc over 1 year ago

  • Status changed from ASSIGNED to POST

#14 Updated by ttereshc over 1 year ago

  • Sprint changed from Sprint 54 to Sprint 55

#15 Updated by dominiclay123@gmail.com over 1 year ago

  • File clipboard-201906251113-1pik0.png added

#16 Updated by bmbouter over 1 year ago

  • File deleted (clipboard-201906251113-1pik0.png)

#17 Updated by ttereshc over 1 year ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#18 Updated by ttereshc 12 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF