Project

Profile

Help

Actions
Send by e-mail Copy link

Refactor #4117

closed

Refactor bulk_create calls in RpmContentUnitSaver

Added by bmbouter about 6 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
ttereshc
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 55
Quarter:

Description

The implementation of RpmContentUnitSaver needs to not rely on attaching attributes to models and then reading those attributes back later. For background see comments around this one: https://pulp.plan.io/issues/4060#note-12

That is currently done in the rpm code here: https://github.com/pulp/pulp_rpm/blob/844336c1c55427851861491a50746c1c2af48d4e/pulp_rpm/app/tasks/synchronizing.py#L293-L327

Actions
Copy link
 #1

Updated by bmbouter about 6 years ago

  • Tracker changed from Issue to Refactor
  • Subject changed from Rework bulk_create calls in ErratumContentUnitSaver to Refactor bulk_create calls in ErratumContentUnitSaver
  • % Done set to 0
Actions
Copy link
 #2

Updated by bmbouter about 6 years ago

We could use a zip() style which relies on the bulk_create order of items in and items out being the same. dalley confirmed in #django that it's implementation does preserve order today. Here is an example: https://github.com/pulp/pulp/compare/master...dralley:single-table-content?expand=1#diff-724178b047dc8948469adbef5243c6c0R126

Actions
Copy link
 #3

Updated by ttereshc almost 6 years ago

  • Subject changed from Refactor bulk_create calls in ErratumContentUnitSaver to Refactor bulk_create calls in RpmContentUnitSaver
  • Description updated (diff)
  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions
Copy link
 #4

Updated by ttereshc almost 6 years ago

  • Sprint set to Sprint 50
Actions
Copy link
 #5

Updated by dalley over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to dalley
Actions
Copy link
 #6

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 50 to Sprint 51
Actions
Copy link
 #7

Updated by daviddavis over 5 years ago

  • Sprint changed from Sprint 51 to Sprint 52
Actions
Copy link
 #8

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3)
Actions
Copy link
 #9

Updated by dalley over 5 years ago

  • Status changed from ASSIGNED to NEW
  • Assignee deleted (dalley)

Working on higher priority items currently - anyone else can pick this up. I never got very far on my branch.

Actions
Copy link
 #10

Updated by rchan over 5 years ago

  • Sprint changed from Sprint 52 to Sprint 53
Actions
Copy link
 #11

Updated by amacdona@redhat.com over 5 years ago

  • Sprint changed from Sprint 53 to Sprint 54
Actions
Copy link
 #12

Updated by ttereshc over 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc
Actions
Copy link
 #13

Updated by ttereshc over 5 years ago

  • Status changed from ASSIGNED to POST
Actions
Copy link
 #14

Updated by ttereshc over 5 years ago

  • Sprint changed from Sprint 54 to Sprint 55
Actions
Copy link
 #15

Updated by dominiclay123@gmail.com over 5 years ago

  • File clipboard-201906251113-1pik0.png added
Actions
Copy link
 #16

Updated by bmbouter over 5 years ago

  • File deleted (clipboard-201906251113-1pik0.png)

Added by ttereshc over 5 years ago

Revision 6f58b19b | View on GitHub

Stop using model attributes to carry related models to save later

Use extra_data attribute of DeclarativeContent instead.

closes #4117 https://pulp.plan.io/issues/4117

Actions
Copy link
 #17

Updated by ttereshc over 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #18

Updated by ttereshc about 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF