Task #4041
Determine impact of blank=True when null=True on all models.
100%
Description
A recent PR raised the question of: Do the fields with null=True also need blank=True? If so, which types of fields and why. This may be determined by reading docs but will likely need to include some testing. After making the determination, all the models should be updated to be constant.
The PR was for the Publication.publisher (FK). null=True was added but not blank=True. Seemed to work but question was raised about the browsable API.
Associated revisions
Revision d9d080ab
View on GitHub
Removal of 'blank' argument from models
No need of its usage as all checks are done with django rest framework
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Revision d9d080ab
View on GitHub
Removal of 'blank' argument from models
No need of its usage as all checks are done with django rest framework
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Revision 327e67eb
View on GitHub
Remove blank argument from model
as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Revision 7fb23b85
View on GitHub
Remove blank argument from model
as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok
https://pulp.plan.io/issues/4041
closes #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
History
#1
Updated by daviddavis over 2 years ago
- Tracker changed from Issue to Task
- % Done set to 0
- Groomed changed from No to Yes
- Sprint set to Sprint 43
#2
Updated by ppicka over 2 years ago
- Assignee set to ppicka
#3
Updated by rchan over 2 years ago
- Sprint changed from Sprint 43 to Sprint 44
#4
Updated by ppicka over 2 years ago
As found by reading docs, and some test "blank=True" is for django form (django admin and custom forms) and as we checking by django rest framework and for browsable UI using djangorestframework we do not need to use this at all.
#5
Updated by jortel@redhat.com over 2 years ago
- Status changed from NEW to ASSIGNED
#6
Updated by rchan about 2 years ago
- Sprint changed from Sprint 44 to Sprint 45
#7
Updated by ppicka about 2 years ago
added
https://github.com/pulp/pulp/pull/3741 - pulpcore
https://github.com/pulp/pulp_file/pull/130 - pulp_file
#8
Updated by ppicka about 2 years ago
https://github.com/pulp/pulp_python/pull/208 - pulp_python
#9
Updated by ppicka about 2 years ago
added https://github.com/pulp/pulp_rpm/pull/1220 [pulp_rpm] but need to wait for daviddavis https://github.com/pulp/pulp_rpm/pull/1223 to fix travis inside pulp_rpm repo
#10
Updated by rchan about 2 years ago
- Sprint changed from Sprint 45 to Sprint 46
#11
Updated by rchan about 2 years ago
- Sprint changed from Sprint 46 to Sprint 47
#12
Updated by ppicka about 2 years ago
- Status changed from ASSIGNED to POST
#13
Updated by ppicka about 2 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp_rpm:7fb23b85cd315a4752e47cc1db680abbdd1b237e.
#14
Updated by daviddavis almost 2 years ago
- Sprint/Milestone set to 3.0.0
#15
Updated by bmbouter over 1 year ago
- Tags deleted (
Pulp 3)
#16
Updated by bmbouter about 1 year ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Please register to edit this issue
Remove 'blank' argument from models
No need of its usage as all checks are done with django rest framework
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com