Project

Profile

Help

Task #4041

Determine impact of blank=True when null=True on all models.

Added by jortel@redhat.com over 1 year ago. Updated 6 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
No
Tags:
Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 47

Description

A recent PR raised the question of: Do the fields with null=True also need blank=True? If so, which types of fields and why. This may be determined by reading docs but will likely need to include some testing. After making the determination, all the models should be updated to be constant.

The PR was for the Publication.publisher (FK). null=True was added but not blank=True. Seemed to work but question was raised about the browsable API.

Associated revisions

Revision 12484f90 View on GitHub
Added by ppicka over 1 year ago

Remove 'blank' argument from models

No need of its usage as all checks are done with django rest framework

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka

Revision d9d080ab View on GitHub
Added by ppicka over 1 year ago

Removal of 'blank' argument from models

No need of its usage as all checks are done with django rest framework

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka

Revision d9d080ab View on GitHub
Added by ppicka over 1 year ago

Removal of 'blank' argument from models

No need of its usage as all checks are done with django rest framework

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka

Revision 327e67eb View on GitHub
Added by ppicka over 1 year ago

Remove blank argument from model

as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka

Revision 7fb23b85 View on GitHub
Added by ppicka over 1 year ago

Remove blank argument from model

as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok

https://pulp.plan.io/issues/4041

closes #4041

Signed-off-by: Pavel Picka

History

#1 Updated by daviddavis over 1 year ago

  • Tracker changed from Issue to Task
  • % Done set to 0
  • Groomed changed from No to Yes
  • Sprint set to Sprint 43

#2 Updated by ppicka over 1 year ago

  • Assignee set to ppicka

#3 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 43 to Sprint 44

#4 Updated by ppicka over 1 year ago

As found by reading docs, and some test "blank=True" is for django form (django admin and custom forms) and as we checking by django rest framework and for browsable UI using djangorestframework we do not need to use this at all.

#5 Updated by jortel@redhat.com over 1 year ago

  • Status changed from NEW to ASSIGNED

#6 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 44 to Sprint 45

#9 Updated by ppicka over 1 year ago

added https://github.com/pulp/pulp_rpm/pull/1220 [pulp_rpm] but need to wait for @daviddavis https://github.com/pulp/pulp_rpm/pull/1223 to fix travis inside pulp_rpm repo

#10 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 45 to Sprint 46

#11 Updated by rchan over 1 year ago

  • Sprint changed from Sprint 46 to Sprint 47

#12 Updated by ppicka over 1 year ago

  • Status changed from ASSIGNED to POST

#13 Updated by ppicka over 1 year ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#14 Updated by daviddavis about 1 year ago

  • Sprint/Milestone set to 3.0.0

#15 Updated by bmbouter about 1 year ago

  • Tags deleted (Pulp 3)

#16 Updated by bmbouter 6 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF