Task #4041: Determine impact of blank=True when null=True on all models. - Pulp

Send by e-mail

Task #4041

Determine impact of blank=True when null=True on all models.

Added by jortel@redhat.com over 2 years ago. Updated about 1 year ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

ppicka

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

Groomed:

Yes

Sprint Candidate:

Tags:

Easy Fix

Sprint:

Sprint 47

Quarter:

Description

A recent PR raised the question of: Do the fields with null=True also need blank=True? If so, which types of fields and why. This may be determined by reading docs but will likely need to include some testing. After making the determination, all the models should be updated to be constant.

The PR was for the Publication.publisher (FK). null=True was added but not blank=True. Seemed to work but question was raised about the browsable API.

Associated revisions

Revision 12484f90 View on GitHub
Added by ppicka about 2 years ago

Remove 'blank' argument from models

No need of its usage as all checks are done with django rest framework

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka ppicka@redhat.com

Revision d9d080ab View on GitHub
Added by ppicka about 2 years ago

Removal of 'blank' argument from models

No need of its usage as all checks are done with django rest framework

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka ppicka@redhat.com

Revision d9d080ab View on GitHub
Added by ppicka about 2 years ago

Removal of 'blank' argument from models

No need of its usage as all checks are done with django rest framework

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka ppicka@redhat.com

Revision 327e67eb View on GitHub
Added by ppicka about 2 years ago

Remove blank argument from model

as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok

https://pulp.plan.io/issues/4041

re #4041

Signed-off-by: Pavel Picka ppicka@redhat.com

Revision 7fb23b85 View on GitHub
Added by ppicka about 2 years ago

Remove blank argument from model

as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok

https://pulp.plan.io/issues/4041

closes #4041

Signed-off-by: Pavel Picka ppicka@redhat.com

History

#1 Updated by daviddavis over 2 years ago

Tracker changed from Issue to Task
% Done set to 0
Groomed changed from No to Yes
Sprint set to Sprint 43

#2 Updated by ppicka over 2 years ago

Assignee set to ppicka

#3 Updated by rchan over 2 years ago

Sprint changed from Sprint 43 to Sprint 44

#4 Updated by ppicka over 2 years ago

As found by reading docs, and some test "blank=True" is for django form (django admin and custom forms) and as we checking by django rest framework and for browsable UI using djangorestframework we do not need to use this at all.