Task #4041
closed
Determine impact of blank=True when null=True on all models.
100%
Description
A recent PR raised the question of: Do the fields with null=True also need blank=True? If so, which types of fields and why. This may be determined by reading docs but will likely need to include some testing. After making the determination, all the models should be updated to be constant.
The PR was for the Publication.publisher (FK). null=True was added but not blank=True. Seemed to work but question was raised about the browsable API.
Updated by daviddavis over 5 years ago
- Tracker changed from Issue to Task
- % Done set to 0
- Groomed changed from No to Yes
- Sprint set to Sprint 43
Updated by ppicka over 5 years ago
As found by reading docs, and some test "blank=True" is for django form (django admin and custom forms) and as we checking by django rest framework and for browsable UI using djangorestframework we do not need to use this at all.
Updated by jortel@redhat.com over 5 years ago
- Status changed from NEW to ASSIGNED
Updated by ppicka over 5 years ago
added
https://github.com/pulp/pulp/pull/3741 - pulpcore
https://github.com/pulp/pulp_file/pull/130 - pulp_file
Added by ppicka over 5 years ago
Updated by ppicka over 5 years ago
https://github.com/pulp/pulp_python/pull/208 - pulp_python
Added by ppicka over 5 years ago
Revision d9d080ab | View on GitHub
Removal of 'blank' argument from models
No need of its usage as all checks are done with django rest framework
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Added by ppicka over 5 years ago
Revision d9d080ab | View on GitHub
Removal of 'blank' argument from models
No need of its usage as all checks are done with django rest framework
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Added by ppicka over 5 years ago
Revision 327e67eb | View on GitHub
Remove blank argument from model
as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Updated by ppicka over 5 years ago
added https://github.com/pulp/pulp_rpm/pull/1220 [pulp_rpm] but need to wait for @daviddavis https://github.com/pulp/pulp_rpm/pull/1223 to fix travis inside pulp_rpm repo
Added by ppicka over 5 years ago
Revision 7fb23b85 | View on GitHub
Remove blank argument from model
as 'blank=True' is used for validating by django form (include django admin) we do not need to use it as checking by djangorestframewrok
https://pulp.plan.io/issues/4041
closes #4041
Signed-off-by: Pavel Picka ppicka@redhat.com
Updated by ppicka over 5 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp_rpm:7fb23b85cd315a4752e47cc1db680abbdd1b237e.
Updated by bmbouter over 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Remove 'blank' argument from models
No need of its usage as all checks are done with django rest framework
https://pulp.plan.io/issues/4041
re #4041
Signed-off-by: Pavel Picka ppicka@redhat.com