Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #4037

closed

Can't require a pulp-smash PR

Added by daviddavis over 5 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
daviddavis
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 43
Quarter:

Description

The CI docs mention how you can require a pulp-smash PR if you have a PR that requires changes in pulp-smash:

https://docs.pulpproject.org/en/3.0/nightly/contributing/continuous-integration.html#requiring-other-pull-requests

However it looks like this functionality was removed:

https://github.com/pulp/pulp/commit/1f48e961da3576e587bece7f02101d1c12e42d3a#diff-60f45dbdd96bd53a91fbbadd0b05b43aL27

I wonder if we should bring this functionality back because sometimes PRs against Pulp do require changes to pulp-smash. Here is a recent example in which we changed the postponed response:

https://github.com/pulp/pulp/pull/3631

At the very least though, we should update our docs.

Actions
Send by e-mail Copy link

Also available in: Atom PDF