Project

Profile

Help

Issue #4037

Can't require a pulp-smash PR

Added by daviddavis about 1 year ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 43

Description

The CI docs mention how you can require a pulp-smash PR if you have a PR that requires changes in pulp-smash:

https://docs.pulpproject.org/en/3.0/nightly/contributing/continuous-integration.html#requiring-other-pull-requests

However it looks like this functionality was removed:

https://github.com/pulp/pulp/commit/1f48e961da3576e587bece7f02101d1c12e42d3a#diff-60f45dbdd96bd53a91fbbadd0b05b43aL27

I wonder if we should bring this functionality back because sometimes PRs against Pulp do require changes to pulp-smash. Here is a recent example in which we changed the postponed response:

https://github.com/pulp/pulp/pull/3631

At the very least though, we should update our docs.

Associated revisions

Revision c2f277bf View on GitHub
Added by daviddavis about 1 year ago

Allow commits to require pulp-smash PRs

fixes #4037
https://pulp.plan.io/issues/4037

Revision c2f277bf View on GitHub
Added by daviddavis about 1 year ago

Allow commits to require pulp-smash PRs

fixes #4037
https://pulp.plan.io/issues/4037

Revision c2f277bf View on GitHub
Added by daviddavis about 1 year ago

Allow commits to require pulp-smash PRs

fixes #4037
https://pulp.plan.io/issues/4037

History

#1 Updated by dkliban@redhat.com about 1 year ago

We should bring back this functionality instead of updating the docs.

#2 Updated by dkliban@redhat.com about 1 year ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 43

#3 Updated by daviddavis about 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#4 Updated by daviddavis about 1 year ago

  • Status changed from ASSIGNED to POST

#5 Updated by daviddavis about 1 year ago

  • Status changed from POST to MODIFIED

#6 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#7 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF