Actions
Issue #4037
closed
Can't require a pulp-smash PR
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 43
Quarter:
Description
The CI docs mention how you can require a pulp-smash PR if you have a PR that requires changes in pulp-smash:
However it looks like this functionality was removed:
I wonder if we should bring this functionality back because sometimes PRs against Pulp do require changes to pulp-smash. Here is a recent example in which we changed the postponed response:
https://github.com/pulp/pulp/pull/3631
At the very least though, we should update our docs.
Updated by dkliban@redhat.com over 5 years ago
We should bring back this functionality instead of updating the docs.
Updated by dkliban@redhat.com over 5 years ago
- Triaged changed from No to Yes
- Sprint set to Sprint 43
Updated by daviddavis over 5 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to daviddavis
Updated by daviddavis over 5 years ago
- Status changed from ASSIGNED to POST
Added by daviddavis over 5 years ago
Added by daviddavis over 5 years ago
Revision c2f277bf | View on GitHub
Allow commits to require pulp-smash PRs
Updated by daviddavis over 5 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|c2f277bf556a814808dca706f2bb57b9bf422091.
Updated by bmbouter over 4 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
.
Allow commits to require pulp-smash PRs
fixes #4037 https://pulp.plan.io/issues/4037