Project

Profile

Help

Task #3930

closed

Validate commit messages

Added by daviddavis over 4 years ago. Updated almost 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 42
Quarter:

Description

The Problem

Two problems we have dealt with recently:

  • A commit was attached to an issue that was already released. Thus the commit was left out of the build it was intended for.
  • A commit for an issue got merged that was not attached to the issue. This commit was also left out of a build.

Solution

The solution we'd like to propose is to validate that each commit message is:

  • attached to an issue
  • the issue is in the correct state (NEW, ASSIGNED, POST, or MODIFIED)

We discussed that this should be non-blocking as sometimes commits for small items (fixing typos) don't need an issue. However, this is tricky as Travis can only pass/fail PRs.

I'd propose that commit messages that aren't attached to issues have the tag "#noissue" in them. This would exclude them from this validation.

Actions #1

Updated by daviddavis over 4 years ago

  • Description updated (diff)
Actions #2

Updated by daviddavis over 4 years ago

  • Description updated (diff)
Actions #3

Updated by amacdona@redhat.com over 4 years ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #4

Updated by daviddavis over 4 years ago

  • Priority changed from Normal to Low
  • Sprint set to Sprint 42
Actions #5

Updated by daviddavis over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions #6

Updated by daviddavis over 4 years ago

  • Status changed from ASSIGNED to POST

Added by daviddavis about 4 years ago

Revision 7f0e8141

Have Travis validate commit messages

Created a script to validate commit messages. This first pass checks for issues in the commit message and makes sure they're in the correct state.

fixes #3930 https://pulp.plan.io/issues/3930

Added by daviddavis about 4 years ago

Revision 7f0e8141

Have Travis validate commit messages

Created a script to validate commit messages. This first pass checks for issues in the commit message and makes sure they're in the correct state.

fixes #3930 https://pulp.plan.io/issues/3930

Actions #7

Updated by daviddavis about 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #8

Updated by dkliban@redhat.com about 4 years ago

  • Tags Pulp 3 added
Actions #9

Updated by daviddavis over 3 years ago

  • Sprint/Milestone set to 3.0.0
Actions #10

Updated by bmbouter over 3 years ago

  • Tags deleted (Pulp 3)
Actions #11

Updated by bmbouter almost 3 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Also available in: Atom PDF