Project

Profile

Help

Task #3930

Validate commit messages

Added by daviddavis about 1 year ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Low
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Platform Release:
Blocks Release:
Backwards Incompatible:
No
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 42

Description

The Problem

Two problems we have dealt with recently:

  • A commit was attached to an issue that was already released. Thus the commit was left out of the build it was intended for.
  • A commit for an issue got merged that was not attached to the issue. This commit was also left out of a build.

Solution

The solution we'd like to propose is to validate that each commit message is:

  • attached to an issue
  • the issue is in the correct state (NEW, ASSIGNED, POST, or MODIFIED)

We discussed that this should be non-blocking as sometimes commits for small items (fixing typos) don't need an issue. However, this is tricky as Travis can only pass/fail PRs.

I'd propose that commit messages that aren't attached to issues have the tag "#noissue" in them. This would exclude them from this validation.

Associated revisions

Revision 7f0e8141 View on GitHub
Added by daviddavis about 1 year ago

Have Travis validate commit messages

Created a script to validate commit messages. This first pass checks for
issues in the commit message and makes sure they're in the correct
state.

fixes #3930
https://pulp.plan.io/issues/3930

Revision 7f0e8141 View on GitHub
Added by daviddavis about 1 year ago

Have Travis validate commit messages

Created a script to validate commit messages. This first pass checks for
issues in the commit message and makes sure they're in the correct
state.

fixes #3930
https://pulp.plan.io/issues/3930

Revision 7f0e8141 View on GitHub
Added by daviddavis about 1 year ago

Have Travis validate commit messages

Created a script to validate commit messages. This first pass checks for
issues in the commit message and makes sure they're in the correct
state.

fixes #3930
https://pulp.plan.io/issues/3930

History

#1 Updated by daviddavis about 1 year ago

  • Description updated (diff)

#2 Updated by daviddavis about 1 year ago

  • Description updated (diff)

#3 Updated by amacdona@redhat.com about 1 year ago

  • Groomed changed from No to Yes
  • Sprint Candidate changed from No to Yes

#4 Updated by daviddavis about 1 year ago

  • Priority changed from Normal to Low
  • Sprint set to Sprint 42

#5 Updated by daviddavis about 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#6 Updated by daviddavis about 1 year ago

  • Status changed from ASSIGNED to POST

#7 Updated by daviddavis about 1 year ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#8 Updated by dkliban@redhat.com about 1 year ago

  • Tags Pulp 3 added

#9 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#10 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF