Project

Profile

Help

Issue #3878

Published metadata path is saved to None path

Added by daviddavis almost 2 years ago. Updated 6 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 41

Description

In task #3848, we converted ids from being UUIDs to integer IDs. The advantage of UUIDs is that they can be set before the model is saved. We rely on this here when setting the path to the published metadata:

https://github.com/pulp/pulp/blob/b3adca1dde4658f87c6dd9109fd5969617845203/pulpcore/pulpcore/app/models/storage.py#L144

However, now that we're using int ids (which are set after save), published metadata is getting saved to /var/lib/pulp/published/metadata/None/.

I believe we should be able to simply substitute model.pk with something like uuid4().

Associated revisions

Revision 5caa01f4 View on GitHub
Added by jortel@redhat.com almost 2 years ago

Fix storage path for published metadata. closes #3878

Revision 5caa01f4 View on GitHub
Added by jortel@redhat.com almost 2 years ago

Fix storage path for published metadata. closes #3878

History

#1 Updated by jortel@redhat.com almost 2 years ago

wrote:

I believe we should be able to simply substitute model.pk with something like uuid4().

Seems like a good solution.

I don't know of any need for linkage back to the PublishedMetadata in the DB.

#2 Updated by CodeHeeler almost 2 years ago

  • Triaged changed from No to Yes
  • Sprint set to Sprint 40

#3 Updated by jortel@redhat.com almost 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to jortel@redhat.com

#4 Updated by rchan almost 2 years ago

  • Sprint changed from Sprint 40 to Sprint 41

#5 Updated by jortel@redhat.com almost 2 years ago

  • Status changed from ASSIGNED to POST

#6 Updated by jortel@redhat.com almost 2 years ago

  • Status changed from POST to MODIFIED

#7 Updated by daviddavis about 1 year ago

  • Sprint/Milestone set to 3.0.0

#8 Updated by bmbouter about 1 year ago

  • Tags deleted (Pulp 3)

#9 Updated by bmbouter 6 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF