Project

Profile

Help

Issue #3476

closed

Base path validation on distributions doesn't work depending on your hostname

Added by daviddavis about 6 years ago. Updated over 4 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Sprint 34
Quarter:

Description

Ichimonji10 discovered that perfectly valid hostnames weren't being accepted after this PR got merged:

https://github.com/pulp/pulp/pull/3371

We're using django's URLValidator which apparently looks for a dot in the hostname:

https://github.com/django/django/blob/master/django/core/validators.py#L86

That is except if you are using localhost:

https://github.com/django/django/blob/master/django/core/validators.py#L93

Also available in: Atom PDF