Project

Profile

Help

Issue #3440

closed

It is not possible to skip SRPMs during sync, only together with RPMs

Added by paji@redhat.com about 6 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.16.1
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
Yes
Tags:
Pulp 2
Sprint:
Sprint 34
Quarter:

Description

This feature is needed by Suse users in particular. Suse it appears bundles both rpms and srpms in the same repo. As a user I would like to say "ignore srpm"

Pulp document https://docs.pulpproject.org/plugins/pulp_rpm/tech-reference/yum-plugins.html#yum-importer does not list srpm as a valid option for skip

skip
    List of content types to be skipped during the repository synchronization. If unspecified, all types will be synchronized. Valid values are: rpm, drpm, distribution, erratum; default is [].

It was mentioned to me a possible documentation issue.

So I then tried it via pulp-admin and hit the same problem

$ pulp rpm repo create --repo-id=j123 --feed=http://<fqdn>/upstream-repo --skip=srpm      

Validation failed for argument [--skip]: Types must be a comma-separated list                        using only the following values: rpm, drpm, distribution, erratum                                   

Finally I side stepped pulp-admin and interacted with the repo api to create a repo with a skip list that asked it to ignore srpm. The upstream repo had 2 rpms and 1 srpm. I then synced and noticed that srpm was ignored. So it looks like this is truly not supported option for yum and needs to be fixed. (notice the Type Skip List: srpm below and notice the content counts showing 1 srpm)

$ pulp rpm repo list --repo-id=88f4965f-ea84-48d3-badf-3fad15fe1464 --detail
+----------------------------------------------------------------------+
                            RPM Repositories
+----------------------------------------------------------------------+

Id:                   88f4965f-ea84-48d3-badf-3fad15fe1464
Display Name:         suse
Description:          None
Content Unit Counts:  
  Rpm:  2
  Srpm: 1
Notes:                
Scratchpad:           
  Checksum Type: sha256
Importers:            
  Config:               
    Download Policy: on_demand
    Feed:            http://<url>:4040
    Remove Missing:  True
    SSL Validation:  True
    Type Skip List:  srpm
  Id:                   yum_importer
  Importer Type Id:     yum_importer
  Last Override Config: 
    Num Threads: 4
    Validate:    True
  Last Sync:            2018-03-06T07:36:50Z
  Last Updated:         2018-03-06T07:32:24Z
  Repo Id:              88f4965f-ea84-48d3-badf-3fad15fe1464
  Scratchpad:           
    Repomd Revision: 1520368693
Distributors:         
  Auto Publish:         False
  Config:               
    Http:         False
    Https:        False
    Relative URL: Default_Organization/Library/custom/justin/suse
  Distributor Type Id:  export_distributor
  Id:                   export_distributor
  Last Override Config: 
  Last Publish:         None
  Last Updated:         2018-03-06T07:32:24Z
  Repo Id:              88f4965f-ea84-48d3-badf-3fad15fe1464
  Scratchpad:           
  Auto Publish:         False
  Config:               
    Destination Distributor Id: 88f4965f-ea84-48d3-badf-3fad15fe1464
  Distributor Type Id:  yum_clone_distributor
  Id:                   88f4965f-ea84-48d3-badf-3fad15fe1464_clone
  Last Override Config: 
  Last Publish:         None
  Last Updated:         2018-03-06T07:32:24Z
  Repo Id:              88f4965f-ea84-48d3-badf-3fad15fe1464
  Scratchpad:           
  Auto Publish:         True
  Config:               
    Checksum Type: sha256
    Http:          True
    Https:         True
    Protected:     True
    Relative URL:  Default_Organization/Library/custom/justin/suse
  Distributor Type Id:  yum_distributor
  Id:                   88f4965f-ea84-48d3-badf-3fad15fe1464
  Last Override Config: 
  Last Publish:         2018-03-06T07:36:50Z
  Last Updated:         2018-03-06T07:36:50Z
  Repo Id:              88f4965f-ea84-48d3-badf-3fad15fe1464
  Scratchpad:
Actions #2

Updated by ttereshc about 6 years ago

  • Project changed from Infrastructure to RPM Support
  • Subject changed from Rpm skip importer not skipping srpms to It is not possible to skip SRPMs during sync, only together with RPMs

It seems like RPMs and SRPMs are treated as the same at the point when decision what to download is made.

Partha confirmed that if one tries to skip RPMs during sync, SRPMs are skipped as well.

Actions #3

Updated by ttereshc about 6 years ago

  • Triaged changed from No to Yes
  • Sprint Candidate changed from No to Yes
Actions #5

Updated by ttereshc almost 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc
  • Sprint set to Sprint 34

Added by ttereshc almost 6 years ago

Revision b0e8f4f9 | View on GitHub

Respect SRPM skip option during sync

closes #3440 https://pulp.plan.io/issues/3440

Actions #6

Updated by ttereshc almost 6 years ago

  • Status changed from ASSIGNED to POST
Actions #7

Updated by ttereshc almost 6 years ago

  • Status changed from POST to MODIFIED
Actions #8

Updated by bmbouter almost 6 years ago

  • Platform Release set to 2.16.1

Marking for inclusion in 2.16.1

Added by ttereshc almost 6 years ago

Revision 6db3dc41 | View on GitHub

Respect SRPM skip option during sync

closes #3440 https://pulp.plan.io/issues/3440

(cherry picked from commit b0e8f4f9bf04e8201fcc32873e1d0836be4b7ef3)

Actions #9

Updated by ttereshc almost 6 years ago

Actions #10

Updated by bmbouter almost 6 years ago

  • Status changed from MODIFIED to 5
Actions #11

Updated by bmbouter almost 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #12

Updated by bmbouter almost 5 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF