Project

Profile

Help

Issue #3406

/var/cache/pulp should not be required by pulp workers

Added by dkliban@redhat.com over 1 year ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 34

Description

In Pulp 2, /var/cache/pulp was used by workers to create symlinks before copying them to /var/lib/pulp. Since Pulp 3 is not going to be creating symlinks all the time, it's reasonable to believe that workers can use /var/lib/pulp/tmp as the root of their working directories.

We should switch the code that provides the working directory for a worker to return /var/lib/pulp/tmp/<workername>

The Artifact upload API already uses /var/lib/pulp/tmp as the temporary storage.

Associated revisions

Revision 310dbb1a View on GitHub
Added by daviddavis over 1 year ago

Drop creation of the /var/cache/pulp directory

ref #3406
https://pulp.plan.io/issues/3406

Revision 4ec2f54b View on GitHub
Added by daviddavis over 1 year ago

Using /var/lib/pulp/tmp instead of /var/cache/pulp

fixes #3406
https://pulp.plan.io/issues/3406

Revision 4ec2f54b View on GitHub
Added by daviddavis over 1 year ago

Using /var/lib/pulp/tmp instead of /var/cache/pulp

fixes #3406
https://pulp.plan.io/issues/3406

Revision 4ec2f54b View on GitHub
Added by daviddavis over 1 year ago

Using /var/lib/pulp/tmp instead of /var/cache/pulp

fixes #3406
https://pulp.plan.io/issues/3406

History

#1 Updated by dkliban@redhat.com over 1 year ago

  • Description updated (diff)

#2 Updated by bmbouter over 1 year ago

To avoid an artifact and worker name collision (which is unlikely), maybe the artifact path should go one level deeper to be /var/lib/pulp/tmp/artifacts/. Just an idea.

#4 Updated by dalley over 1 year ago

  • Subject changed from /var/cache/pulp shoudl not be required by pulp workers to /var/cache/pulp should not be required by pulp workers
  • Sprint/Milestone set to 56
  • Triaged changed from No to Yes

#5 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 33

#6 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (56)

#7 Updated by jortel@redhat.com over 1 year ago

  • Sprint changed from Sprint 33 to Sprint 34

#8 Updated by daviddavis over 1 year ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#9 Updated by daviddavis over 1 year ago

@bmbouter I think we're good. Looks like artifacts won't create a collision as the storage service uses /var/lib/pulp/tmp/<task id>/:

https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/tasking/services/storage.py#L130-L148

#11 Updated by daviddavis over 1 year ago

  • Status changed from POST to MODIFIED

#12 Updated by dkliban@redhat.com over 1 year ago

  • Sprint/Milestone set to 3.0

#13 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)

Please register to edit this issue

Also available in: Atom PDF