Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #3406

closed

/var/cache/pulp should not be required by pulp workers

Added by dkliban@redhat.com over 6 years ago. Updated almost 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
daviddavis
Category:
-
Sprint/Milestone:
3.0.0
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix
Sprint:
Sprint 34
Quarter:

Description

In Pulp 2, /var/cache/pulp was used by workers to create symlinks before copying them to /var/lib/pulp. Since Pulp 3 is not going to be creating symlinks all the time, it's reasonable to believe that workers can use /var/lib/pulp/tmp as the root of their working directories.

We should switch the code that provides the working directory for a worker to return /var/lib/pulp/tmp/<workername>

The Artifact upload API already uses /var/lib/pulp/tmp as the temporary storage.

Actions
Copy link
 #1

Updated by dkliban@redhat.com over 6 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by bmbouter over 6 years ago

To avoid an artifact and worker name collision (which is unlikely), maybe the artifact path should go one level deeper to be /var/lib/pulp/tmp/artifacts/. Just an idea.

Actions
Copy link
 #4

Updated by dalley over 6 years ago

  • Subject changed from /var/cache/pulp shoudl not be required by pulp workers to /var/cache/pulp should not be required by pulp workers
  • Sprint/Milestone set to 56
  • Triaged changed from No to Yes
Actions
Copy link
 #5

Updated by bmbouter over 6 years ago

  • Sprint set to Sprint 33
Actions
Copy link
 #6

Updated by bmbouter over 6 years ago

  • Sprint/Milestone deleted (56)
Actions
Copy link
 #7

Updated by jortel@redhat.com over 6 years ago

  • Sprint changed from Sprint 33 to Sprint 34
Actions
Copy link
 #8

Updated by daviddavis over 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis
Actions
Copy link
 #9

Updated by daviddavis over 6 years ago

bmbouter I think we're good. Looks like artifacts won't create a collision as the storage service uses /var/lib/pulp/tmp/<task id>/:

https://github.com/pulp/pulp/blob/3.0-dev/pulpcore/pulpcore/tasking/services/storage.py#L130-L148

Added by daviddavis over 6 years ago

Revision 310dbb1a | View on GitHub

Drop creation of the /var/cache/pulp directory

ref #3406 https://pulp.plan.io/issues/3406

Added by daviddavis over 6 years ago

Revision 4ec2f54b | View on GitHub

Using /var/lib/pulp/tmp instead of /var/cache/pulp

fixes #3406 https://pulp.plan.io/issues/3406

Added by daviddavis over 6 years ago

Revision 4ec2f54b | View on GitHub

Using /var/lib/pulp/tmp instead of /var/cache/pulp

fixes #3406 https://pulp.plan.io/issues/3406

Actions
Copy link
 #11

Updated by daviddavis over 6 years ago

  • Status changed from POST to MODIFIED
Actions
Copy link
 #12

Updated by dkliban@redhat.com over 6 years ago

  • Sprint/Milestone set to 3.0.0
Actions
Copy link
 #13

Updated by bmbouter over 5 years ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)
Actions
Copy link
 #14

Updated by bmbouter almost 5 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions
Send by e-mail Copy link

Also available in: Atom PDF