Actions
Issue #3276
closed
CreatedResource can only serialize objects whose href is their pk
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Sprint:
Quarter:
Description
The CreatedResource is serialized on a Task as the href to the resource.
Here is the offending line:
https://github.com/pulp/pulp/blob/2904dd1c6fa947244c0bb98ca5b84acba15f188e/pulpcore/pulpcore/app/serializers/task.py#L27
This works for Publications and any other resource whose href has pk as the only url parameter. It doesn't work for resources whose href has url parameters, like RepositoryVersion.
reverse for Publications uses only "pk"
http://pulp3.dev:8000/api/v3/publications/56a08642-a9d8-42bb-91dd-d1f5021124dd/
reverse for RepositoryVersion needs "repository_pk", "number"
http://pulp3.dev:8000/api/v3/repositories/026b1ce6-8959-43a7-ac63-54a809dea4b6/versions/6/
Actions
.
Make CreatedResource serialize any resource
Using the model's serializer rather than reverse allows us to generate hrefs for objects that use any set of url parameters.
closes #3276 https://pulp.plan.io/issues/3276