Issue #3276
CreatedResource can only serialize objects whose href is their pk
Description
The CreatedResource is serialized on a Task as the href to the resource.
Here is the offending line:
https://github.com/pulp/pulp/blob/2904dd1c6fa947244c0bb98ca5b84acba15f188e/pulpcore/pulpcore/app/serializers/task.py#L27
This works for Publications and any other resource whose href has pk as the only url parameter. It doesn't work for resources whose href has url parameters, like RepositoryVersion.
reverse for Publications uses only "pk"
http://pulp3.dev:8000/api/v3/publications/56a08642-a9d8-42bb-91dd-d1f5021124dd/
reverse for RepositoryVersion needs "repository_pk", "number"
http://pulp3.dev:8000/api/v3/repositories/026b1ce6-8959-43a7-ac63-54a809dea4b6/versions/6/
Associated revisions
Revision e894e19e
View on GitHub
Make CreatedResource serialize any resource
Using the model's serializer rather than reverse allows us to generate
hrefs for objects that use any set of url parameters.
Revision e894e19e
View on GitHub
Make CreatedResource serialize any resource
Using the model's serializer rather than reverse allows us to generate
hrefs for objects that use any set of url parameters.
Revision e894e19e
View on GitHub
Make CreatedResource serialize any resource
Using the model's serializer rather than reverse allows us to generate
hrefs for objects that use any set of url parameters.
History
#1
Updated by amacdona@redhat.com almost 2 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to amacdona@redhat.com
#2
Updated by amacdona@redhat.com almost 2 years ago
- Status changed from ASSIGNED to POST
#3
Updated by amacdona@redhat.com almost 2 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp|e894e19e134ec7a3a90e7bd733985a664558d6ec.
#4
Updated by dkliban@redhat.com over 1 year ago
- Tags Pulp 3, Pulp 3 MVP added
#5
Updated by dkliban@redhat.com over 1 year ago
- Sprint/Milestone set to 3.0
Please register to edit this issue
.