Project

Profile

Help

Issue #3233

Story #3209: As a user, I have Repository Versions

Version incorrectly says that it removed a content unit

Added by daviddavis almost 2 years ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 31

Description

The squash code has a bug. Suppose you have 3 repo versions. Version 1 adds a unit, version 2 removes the unit, and version 3 re-adds the unit. If you remove version 2 then you have 2 RepositoryContent records pointing to version 3—one where version_removed is version 3 (but version_added is still version 1) and one where version_added is version 3. So the unit appears in 'removed' but is still in version 3's content.

Associated revisions

Revision b210be34 View on GitHub
Added by werwty almost 2 years ago

Update repo version squash logic to deal with content removed but readded

Repo version squash should be resolved according to this design:
https://github.com/pulp/pulp/pull/3228#issuecomment-347659974

fixes #3233
https://pulp.plan.io/issues/3233

Revision b210be34 View on GitHub
Added by werwty almost 2 years ago

Update repo version squash logic to deal with content removed but readded

Repo version squash should be resolved according to this design:
https://github.com/pulp/pulp/pull/3228#issuecomment-347659974

fixes #3233
https://pulp.plan.io/issues/3233

Revision b210be34 View on GitHub
Added by werwty almost 2 years ago

Update repo version squash logic to deal with content removed but readded

Repo version squash should be resolved according to this design:
https://github.com/pulp/pulp/pull/3228#issuecomment-347659974

fixes #3233
https://pulp.plan.io/issues/3233

History

#1 Updated by daviddavis almost 2 years ago

  • Tags Pulp 3, Pulp 3 MVP added

#2 Updated by daviddavis almost 2 years ago

  • Parent task set to #3209

#3 Updated by dalley almost 2 years ago

  • Sprint/Milestone set to 52
  • Triaged changed from No to Yes

#4 Updated by bizhang almost 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to bizhang

#5 Updated by rchan almost 2 years ago

  • Sprint/Milestone changed from 52 to 53

#6 Updated by bizhang almost 2 years ago

  • Status changed from ASSIGNED to POST

#8 Updated by werwty almost 2 years ago

  • Status changed from POST to MODIFIED

#9 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 31

#10 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (53)

#11 Updated by dkliban@redhat.com over 1 year ago

  • Sprint/Milestone set to 3.0

#12 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3, Pulp 3 MVP)

Please register to edit this issue

Also available in: Atom PDF