Project

Profile

Help

Refactor #3113

Update Artifact instantiation code to use paths to files

Added by dkliban@redhat.com about 3 years ago. Updated 12 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
% Done:

100%

Estimated time:
Platform Release:
Groomed:
Yes
Sprint Candidate:
No
Tags:
Sprint:
Sprint 28
Quarter:

Description

The Artifact model can be instantiated using an open file or a path to a file on disk. The code in the ChangeSet needs to be updated to stop opening files before instantiating the Artifact. Both of the importers in the example plugin currently open a file before instantiating an Artifact. Both importers need to stop doing this and simply pass in a path to the file when instantiating an Artifact.

The ArtifactFileFiled needs to be updated to open the file in binary mode[0].

[0] https://github.com/pulp/pulp/blob/15857fb0831c0998219a32e8d6ba52abdba20888/platform/pulpcore/app/models/fields.py#L26

Associated revisions

Revision a1f85a46 View on GitHub
Added by ttereshc about 3 years ago

Specify a path instead of an open file for Artifact instantiation

closes #3113 https://pulp.plan.io/issues/3113

Revision a1f85a46 View on GitHub
Added by ttereshc about 3 years ago

Specify a path instead of an open file for Artifact instantiation

closes #3113 https://pulp.plan.io/issues/3113

History

#1 Updated by daviddavis about 3 years ago

  • Groomed changed from No to Yes

#2 Updated by mhrivnak about 3 years ago

  • Sprint/Milestone set to 47

#3 Updated by dkliban@redhat.com about 3 years ago

  • Description updated (diff)

#4 Updated by ttereshc about 3 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ttereshc

#6 Updated by ttereshc about 3 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#7 Updated by bmbouter over 2 years ago

  • Sprint set to Sprint 28

#8 Updated by bmbouter over 2 years ago

  • Sprint/Milestone deleted (47)

#9 Updated by daviddavis over 1 year ago

  • Sprint/Milestone set to 3.0.0

#10 Updated by bmbouter over 1 year ago

  • Tags deleted (Pulp 3)

#11 Updated by bmbouter 12 months ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue

Also available in: Atom PDF