Actions
Issue #3015
closedSensitive data is visible in task results in case of download failures
Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
Yes
Tags:
Sprint:
Sprint 26
Quarter:
Description
To reproduce: sync repo which misses some files to cause download failures: https://repos.fedorapeople.org/pulp/pulp/fixtures/file-mixed/PULP_MANIFEST
Check description of non-fatal errors, it contains all the configuration details for the downloader, including password and SSL key (in the output below those params are not configured at all for the importer and thus empty).
This data is added here for HttpDownload
and here for FtpDownload
.
HTTP 200 OK
Allow: GET, OPTIONS
Content-Type: application/json
Vary: Accept
{
"_href": "http://127.0.0.1:8000/api/v3/tasks/6709dd9e-3ee1-4343-8d6f-a28b77a8d92b/",
"group": null,
"state": "completed",
"started_at": "2017-09-14T23:48:35.283677Z",
"finished_at": "2017-09-14T23:48:36.977364Z",
"non_fatal_errors": [
{
"traceback": null,
"code": null,
"description": "HttpDownload: id=5808 url=https://repos.fedorapeople.org/pulp/pulp/fixtures/file-mixed/missing-1.iso writer=missing-1.iso | repair: retries=1 | timeout: connect=10 read=30 | ssl: validation=False CA= key= certificate= | User: name= password= | proxy= headers={} - Failed. Reason: HTTP [404]"
},
{
"traceback": null,
"code": null,
"description": "HttpDownload: id=5960 url=https://repos.fedorapeople.org/pulp/pulp/fixtures/file-mixed/missing-2.iso writer=missing-2.iso | repair: retries=1 | timeout: connect=10 read=30 | ssl: validation=False CA= key= certificate= | User: name= password= | proxy= headers={} - Failed. Reason: HTTP [404]"
}
],
"error": null,
"worker": "http://127.0.0.1:8000/api/v3/workers/reserved_resource_worker_2@pulp3/",
"parent": null,
"tags": [],
"progress_reports": [
{
"message": "Add Content",
"state": "completed",
"total": 5,
"done": 5,
"suffix": "",
"task": "http://127.0.0.1:8000/api/v3/tasks/6709dd9e-3ee1-4343-8d6f-a28b77a8d92b/"
},
{
"message": "Remove Content",
"state": "completed",
"total": 0,
"done": 0,
"suffix": "",
"task": "http://127.0.0.1:8000/api/v3/tasks/6709dd9e-3ee1-4343-8d6f-a28b77a8d92b/"
}
]
}
Actions
Mask logged password. closes #3015