Project

Profile

Help

Issue #2864

202 response does not include a full URL of the task

Added by dkliban@redhat.com over 2 years ago. Updated 6 months ago.

Status:
MODIFIED
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
Start date:
Due date:
Severity:
2. Medium
Version:
Platform Release:
Blocks Release:
OS:
Backwards Incompatible:
No
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
QA Contact:
Complexity:
Smash Test:
Verified:
No
Verification Required:
No
Sprint:
Sprint 22

Description

PUT /api/v3/importers/file/a5ee9125-9ec9-47ad-bc25-53f24b2d0ce7/

HTTP 202 Accepted
Allow: GET, PUT, PATCH, DELETE, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "_href": "/api/v3/tasks/1aa43f96-ebbb-45a3-9b34-df4546bed817/",
        "task_id": "1aa43f96-ebbb-45a3-9b34-df4546bed817" 
    }
]

The href should be the full URL.

Associated revisions

Revision c82dffb4 View on GitHub
Added by daviddavis over 2 years ago

Convert relative url to full url in 202 responses

fixes #2864
https://pulp.plan.io/issues/2864

Revision c82dffb4 View on GitHub
Added by daviddavis over 2 years ago

Convert relative url to full url in 202 responses

fixes #2864
https://pulp.plan.io/issues/2864

Revision c82dffb4 View on GitHub
Added by daviddavis over 2 years ago

Convert relative url to full url in 202 responses

fixes #2864
https://pulp.plan.io/issues/2864

History

#1 Updated by ttereshc over 2 years ago

  • Description updated (diff)

Just "pre"d the description.

#2 Updated by ttereshc over 2 years ago

  • Sprint/Milestone set to 41
  • Triaged changed from No to Yes

#3 Updated by daviddavis over 2 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to daviddavis

#4 Updated by daviddavis over 2 years ago

Looking at the DRF docs1:

"You should include the request as a keyword argument to the function..."

I think we need to do that on this line:

https://github.com/pulp/pulp/blob/3.0-dev/platform/pulpcore/app/response.py#L33

[1] http://www.django-rest-framework.org/api-guide/reverse/#reverse

#5 Updated by daviddavis over 2 years ago

  • Status changed from ASSIGNED to MODIFIED

#7 Updated by bmbouter over 1 year ago

  • Sprint set to Sprint 22

#8 Updated by bmbouter over 1 year ago

  • Sprint/Milestone deleted (41)

#9 Updated by daviddavis 6 months ago

  • Sprint/Milestone set to 3.0

#10 Updated by bmbouter 6 months ago

  • Tags deleted (Pulp 3)

Please register to edit this issue

Also available in: Atom PDF