Story #2402: As an API user, a call to update an Importer generates a Task - Pulp

Send by e-mail

Story #2402

As an API user, a call to update an Importer generates a Task

Added by ttereshc over 3 years ago. Updated 3 months ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dkliban@redhat.com

Category:

Sprint/Milestone:

3.0.0

Start date:

Due date:

% Done:

100%

Platform Release:

Blocks Release:

Backwards Incompatible:

Groomed:

Yes

Sprint Candidate:

Yes

Tags:

QA Contact:

Complexity:

Smash Test:

Verified:

Verification Required:

Sprint:

Sprint 21

Description

We need to create an update task which can live in pulp.app.tasks.importer.

Task name in Pulp 2: `pulp.server.managers.repo.importer.update_importer_config`.
Task implementation in Pulp 2: https://github.com/pulp/pulp/blob/3.0-dev/server/pulp/server/controllers/importer.py#L240

Hide closed

Checklist

Ensure the viewset uses the serializer to validate the user's data
Create the pulp.app.tasks.importer.update task
Have the viewset call pulp.app.tasks.importer.update task
Write out some commands to test with so the review can easily test
delete old code from /server

Related issues

Associated revisions

Revision f92a4255 View on GitHub
Added by dkliban@redhat.com over 2 years ago

Problem: importer updates are performed syncronously

Solution: override the update method in the Importer viewset

The update method now dispatches a task to update the importer.

closes #2402 https://pulp.plan.io/issues/2402

Revision f92a4255 View on GitHub
Added by dkliban@redhat.com over 2 years ago

Problem: importer updates are performed syncronously

Solution: override the update method in the Importer viewset

The update method now dispatches a task to update the importer.

closes #2402 https://pulp.plan.io/issues/2402

History

#1 Updated by ttereshc over 3 years ago

Related to Task #2380: Create a redmine task for each 2.y celery task to be converted to 3.0 added

#2 Updated by ttereshc over 3 years ago

Tags Pulp 3 added

#3 Updated by mhrivnak over 3 years ago

Groomed changed from No to Yes
Sprint Candidate changed from No to Yes

#4 Updated by mhrivnak about 3 years ago

This comment also applies here: https://pulp.plan.io/issues/2409#note-4

#5 Updated by bmbouter almost 3 years ago

Tracker changed from Task to Story
Subject changed from Convert celery task repo.importer.update_importer_config to Pulp 3 to As an API user, a call to update an importer generates a Task
Description updated (diff)

Rewriting based on similarity to issue 2756 and discussion on the mailing list: https://www.redhat.com/archives/pulp-dev/2017-May/msg00014.html

#6 Updated by bmbouter almost 3 years ago

Subject changed from As an API user, a call to update an importer generates a Task to As an API user, a call to update an Importer generates a Task

#7 Updated by mhrivnak almost 3 years ago

Sprint/Milestone set to 39

#8 Updated by bmbouter almost 3 years ago

Duplicated by Task #2401: Convert celery task repo.importer.set_importer to Pulp 3 added

#9 Updated by dkliban@redhat.com over 2 years ago

Status changed from NEW to ASSIGNED
Assignee set to dkliban@redhat.com

#10 Updated by mhrivnak over 2 years ago

Sprint/Milestone changed from 39 to 40

#11 Updated by dkliban@redhat.com over 2 years ago

Status changed from ASSIGNED to POST

https://github.com/pulp/pulp/pull/3048/

#12 Updated by dkliban@redhat.com over 2 years ago

Status changed from POST to MODIFIED
% Done changed from 0 to 100

Applied in changeset pulp|f92a4255a750f0787f35dcf7b9bc441968f089b4.

#13 Updated by bmbouter almost 2 years ago

Sprint set to Sprint 21

#14 Updated by bmbouter almost 2 years ago

Sprint/Milestone deleted (40)

#15 Updated by daviddavis 10 months ago

Sprint/Milestone set to 3.0.0

#16 Updated by bmbouter 10 months ago

Tags deleted (~~Pulp 3~~)

#17 Updated by bmbouter 3 months ago

Status changed from MODIFIED to CLOSED - CURRENTRELEASE

Please register to edit this issue