Planning on how to support global importer settings
Planning on how to support global importer settings in pulp3 based on this pulp2 story https://pulp.plan.io/issues/1251.Things to consider:
- Are global settings used for importer creation only (Like a template)?
- If not for creation only - what is expected behavior when the global setting changes? Applied to all existing importers?
- Which settings can be global (just credentials, proxy etc)? Limited to just standard settings to also custom settings (fields) added by plugin importer models?
- Are globals stored in the DB?
- How are globals associated (applied) to specific importers? Statically? Dynamically (part of sync call)?
- Could this be address with mass update instead? For example: update proxy_url on all/filtered set of importers?
#1 Updated by bmbouter almost 3 years ago
I don't have opinions on all of these choices, but here are a few first thoughts.
I see the use case as a user wanting to change their proxy config and they need everything now to use the new settings. Based on that understanding, I think we should avoid the templates approach and let the global settings be able to be changed once and take effect for all exiting importers.
Whitelisting a very limited set of fields that this can be done for I think would be safer than having a fully generalized version.
Keeping the config out of the DB will allow us to build less in terms of CRUD operations for that global config. +1 to having them just be a special file on the filesystem.
I'll have to think more about the other questions.
#2 Updated by mhrivnak almost 3 years ago
I've considered the idea of something like a "Download Profile" that could be defined separately from an importer, given a meaningful name, and associated with many importers. Examples a user might create:
- Proxy to Internet
- Proxy to Secret Internal Network
Excluding authentication, users likely don't want or need to have many variations of download settings. They want to use the same settings everywhere, with possibly a small number of use-case-based variations.
It would be good to get feedback on this general concept from users. I also wonder if katello is already doing something along these lines, managing profiles on top of pulp's settings.
#13 Updated by mhrivnak almost 2 years ago
- Status changed from ASSIGNED to POST
Please register to edit this issue