Story #2132: As a consumer of Pulp content I want ISO & ISO_rsync distributor to support relative_url for consistency with yum - RPM Support - Pulp

Actions

Send by e-mail Copy link

Story #2132

closed

As a consumer of Pulp content I want ISO & ISO_rsync distributor to support relative_url for consistency with yum

Added by rmcgover over 7 years ago. Updated about 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

Normal

Assignee:

dkliban@redhat.com

Sprint/Milestone:

Start date:

Due date:

% Done:

100%

Estimated time:

Platform Release:

2.11.0

Groomed:

Yes

Sprint Candidate:

Yes

Tags:

Pulp 2

Sprint:

Sprint 8

Quarter:

Description

In pulp 2.10, yum and rsync distributors have a relative_url config key which allows customizing the directory used for publishing.

ISO distributor doesn't seem to have this and instead will always use a fixed directory layout of {ISO_HTTP_DIR}/{repo.id}.

This inconsistency is confusing to our users and leaks the pulp repo IDs into user-visible locations which is undesired. It would be good to support relative_url also for iso & iso_rsync distributors with the same semantics.

Acceptance criteria:

relative_url is documented under https://docs.pulpproject.org/plugins/pulp_rpm/tech-reference/iso-plugins.html#iso-distributor
relative_url is optional for ISO distributor (for backwards-compat)
if relative_url is set to some/relative/path on iso distributor, then ISO files are published to {ISO_HTTP_DIR}/some/relative/path
if relative_url is set on iso distributor, then iso_rsync_distributor automatically uses it for the publish, with same semantics as how rpm_rsync_distributor uses yum distributor's relative_url.

Actions

Copy link

Updated by dkliban@redhat.com over 7 years ago

Sprint Candidate changed from No to Yes

Actions

Copy link

Updated by dkliban@redhat.com over 7 years ago

Groomed changed from No to Yes

Actions

Copy link

Updated by mhrivnak over 7 years ago

Sprint/Milestone set to 25

Actions

Copy link

Updated by dkliban@redhat.com over 7 years ago

Status changed from NEW to ASSIGNED
Assignee set to dkliban@redhat.com

Actions

Copy link

Updated by bmbouter over 7 years ago

Tags 2.11 added

Actions

Copy link

Updated by mhrivnak over 7 years ago

Sprint/Milestone changed from 25 to 26

Actions

Copy link

Updated by dkliban@redhat.com over 7 years ago

Status changed from ASSIGNED to POST

https://github.com/pulp/pulp_rpm/pull/988/
https://github.com/pulp/pulp/pull/2765

Added by dkliban@redhat.com over 7 years ago

Revision 0aa13525 | View on GitHub

Changes needed to support relative url for ISO repositories

The Q object used to find conflicts for relative url now restricts the search to distributor's of a particular type. This is necesary to allow the same relative URLs for RPM and ISO content.

re: #2132 https://pulp.plan.io/issues/2132

Added by dkliban@redhat.com over 7 years ago

Revision 0aa13525 | View on GitHub

Changes needed to support relative url for ISO repositories

The Q object used to find conflicts for relative url now restricts the search to distributor's of a particular type. This is necesary to allow the same relative URLs for RPM and ISO content.

re: #2132 https://pulp.plan.io/issues/2132

Actions

Copy link

Updated by ipanova@redhat.com over 7 years ago

Tested these steps:
https://github.com/pulp/pulp_rpm/pull/988#issuecomment-248879670

Added by dkliban@redhat.com over 7 years ago

Revision 4255a483 | View on GitHub

Updates API and pulp-admin to accept relative url configuration for ISO content

ISO distributor continues to use the repository id as the default relative URL for the repository. It is now possible to specify the relative url for the ISO distributor using the API and pulp-admin iso repo create/update commands. When then ISO distributor is used as predistributor, the ISO rsync distributor uses the relative url of the predistributor when publishing.

fixes #2132 https://pulp.plan.io/issues/2132

Actions

Copy link

#10