Project

Profile

Help

Actions
Send by e-mail Copy link

Issue #1787

closed

<display_order>None</display_order> in comps.xml

Added by rmcgover about 8 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
ipanova@redhat.com
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Master
Platform Release:
2.9.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 2
Quarter:

Description

If a package_group unit is uploaded with no display_order,
yum distributor's generated XML will contain a group element
with

<display_order>None</display_order>

This is dangerous because yum will crash when parsing such XML.

It would be safer to omit the element, or apply a default, or
force display_order to be set on import.

Actions
Copy link
 #1

Updated by mhrivnak about 8 years ago

  • Parent issue set to #1683
  • Triaged changed from No to Yes
Actions
Copy link
 #2

Updated by mhrivnak almost 8 years ago

We should compare with examples from upstream sources of this data, and make sure the data we publish matches. There is not a known authoritative spec for this file.

This is a great candidate for a smash test.

Actions
Copy link
 #3

Updated by mhrivnak almost 8 years ago

  • Sprint/Milestone set to 20
Actions
Copy link
 #4

Updated by ipanova@redhat.com almost 8 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com
Actions
Copy link
 #5

Updated by ipanova@redhat.com almost 8 years ago

jluza informed me that the default value for display_order is 1024, so if there was not specified any value, 1024 will be set by default

Actions
Copy link
 #6

Updated by ipanova@redhat.com almost 8 years ago

  • Status changed from ASSIGNED to POST
  • Platform Release set to 2.9.0

Added by ipanova@redhat.com almost 8 years ago

Revision 7b23738c | View on GitHub

Assign a default value to display_order.

closes #1787 https://pulp.plan.io/issues/1787

Actions
Copy link
 #7

Updated by ipanova@redhat.com almost 8 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Ichimonji10 almost 8 years ago

The test for this issue is still failing in the nightly Pulp builds. See: http://pulp-smash.readthedocs.io/en/latest/api/pulp_smash.tests.rpm.api_v2.test_comps_groups.html#pulp_smash.tests.rpm.api_v2.test_comps_groups.CompsGroupsTestCase

Please re-open. (Doing so will fix a test failure in our automated test suite.)

Never mind. See: https://github.com/PulpQE/pulp-smash/pull/250

Actions
Copy link
 #9

Updated by pthomas@redhat.com almost 8 years ago

  • Status changed from MODIFIED to 6

Verified as per comment above

Actions
Copy link
 #10

Updated by semyers almost 8 years ago

  • Status changed from 6 to CLOSED - CURRENTRELEASE
Actions
Copy link
 #12

Updated by bmbouter about 6 years ago

  • Sprint set to Sprint 2
Actions
Copy link
 #13

Updated by bmbouter about 6 years ago

  • Sprint/Milestone deleted (20)
Actions
Copy link
 #14

Updated by bmbouter about 5 years ago

  • Tags Pulp 2 added
Actions
Send by e-mail Copy link

Also available in: Atom PDF