Issue #1787
closed<display_order>None</display_order> in comps.xml
Description
If a package_group unit is uploaded with no display_order,
yum distributor's generated XML will contain a group element
with
<display_order>None</display_order>
This is dangerous because yum will crash when parsing such XML.
It would be safer to omit the element, or apply a default, or
force display_order to be set on import.
Updated by mhrivnak almost 9 years ago
- Parent issue set to #1683
- Triaged changed from No to Yes
Updated by mhrivnak almost 9 years ago
We should compare with examples from upstream sources of this data, and make sure the data we publish matches. There is not a known authoritative spec for this file.
This is a great candidate for a smash test.
Updated by ipanova@redhat.com almost 9 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to ipanova@redhat.com
Updated by ipanova@redhat.com almost 9 years ago
jluza informed me that the default value for display_order is 1024, so if there was not specified any value, 1024 will be set by default
Updated by ipanova@redhat.com almost 9 years ago
- Status changed from ASSIGNED to POST
- Platform Release set to 2.9.0
Added by ipanova@redhat.com over 8 years ago
Updated by ipanova@redhat.com over 8 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset 7b23738c259ad976a11b1fe2c3c2062253fb9594.
Updated by Ichimonji10 over 8 years ago
The test for this issue is still failing in the nightly Pulp builds. See: http://pulp-smash.readthedocs.io/en/latest/api/pulp_smash.tests.rpm.api_v2.test_comps_groups.html#pulp_smash.tests.rpm.api_v2.test_comps_groups.CompsGroupsTestCase
Please re-open. (Doing so will fix a test failure in our automated test suite.)
Never mind. See: https://github.com/PulpQE/pulp-smash/pull/250
Updated by pthomas@redhat.com over 8 years ago
- Status changed from MODIFIED to 6
Verified as per comment above
Updated by semyers over 8 years ago
- Status changed from 6 to CLOSED - CURRENTRELEASE
Assign a default value to display_order.
closes #1787 https://pulp.plan.io/issues/1787