Project

Profile

Help

Issue #1635

Pulp fails to reconnect to qpid after a disconnect

Added by dkliban@redhat.com almost 5 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

After python-kombu 3.0.33-1.pulp.fc23 got added to the deps, the reconnect support in Pulp broke.


Checklist

Associated revisions

Revision fbeaa505 View on GitHub
Added by pcreech almost 5 years ago

Add kombu patch for reconnect issue

Adding kombu patch for reconnect issue.

Patch is from https://github.com/celery/kombu/pull/569/

re #1635 https://pulp.plan.io/issues/1635

Revision fbeaa505 View on GitHub
Added by pcreech almost 5 years ago

Add kombu patch for reconnect issue

Adding kombu patch for reconnect issue.

Patch is from https://github.com/celery/kombu/pull/569/

re #1635 https://pulp.plan.io/issues/1635

Revision 4bef5bb3 View on GitHub
Added by bmbouter almost 5 years ago

python-kombu-3.0.33-4.pulp is now included via external_deps.json

closes #1635 https://pulp.plan.io/issues/1635

Revision 4bef5bb3 View on GitHub
Added by bmbouter almost 5 years ago

python-kombu-3.0.33-4.pulp is now included via external_deps.json

closes #1635 https://pulp.plan.io/issues/1635

History

#1 Updated by pthomas@redhat.com almost 5 years ago

  • Subject changed from Pulp fails to reconnect to qpid after a diconnect to Pulp fails to reconnect to qpid after a disconnect

#2 Updated by jortel@redhat.com almost 5 years ago

  • Triaged changed from No to Yes

#3 Updated by bmbouter almost 5 years ago

This is filed against upstream Qpid: https://issues.apache.org/jira/browse/QPID-7053

#4 Updated by bmbouter almost 5 years ago

  • Status changed from NEW to ASSIGNED

#5 Updated by bmbouter almost 5 years ago

This is also being tracked in python-kombu here: https://github.com/celery/kombu/issues/568

#7 Updated by bmbouter almost 5 years ago

I've submitted patches to upstream Qpid and upstream Kombu. These patches work together to resolve the problem. In my testing with these patches applied reconnect support works. Also pulp-smash agrees!

The Kombu patch[0] needs to be added into our python-kombu-3.0.33 and rebuilt in Koji.

[0]: https://patch-diff.githubusercontent.com/raw/celery/kombu/pull/569.patch

#8 Updated by bmbouter almost 5 years ago

  • Checklist item add patch to kombu-3.0.33 that we carry on el6, el6, f22, and f23. Rebuild all in koji added
  • Checklist item wait for Qpid changes to be backported to MRG added
  • Checklist item wait for Qpid changes to land in EL6 Copr repo/EPEL7/F23/F24 and rawhide added
  • Checklist item update external_deps.json on 2.7-dev+ to have us bundle this new python-kombu version with releases added
  • Checklist item update python-kombu in rawhide to carry the kombu patch added

#9 Updated by bmbouter almost 5 years ago

Built in MRG as python-qpid-0.30-9.

Also changes merged in upstream kombu to work with the newly published python-qpid library. That patch has been added to python-kombu we carry python-kombu-3.0.33-4.pulp. That has been built in koji.katello.org. Thanks @pcreech.

#10 Updated by bmbouter almost 5 years ago

  • Checklist item update python-kombu in rawhide to carry the kombu patch set to Done

#11 Updated by bmbouter almost 5 years ago

PR available at: https://github.com/pulp/pulp/pull/2456

This PR cannot be merged until the necessary packages are available in

#12 Updated by bmbouter almost 5 years ago

  • Status changed from ASSIGNED to POST

#13 Updated by bmbouter almost 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#14 Updated by bmbouter almost 5 years ago

  • Checklist item wait for Qpid changes to land in EL6 Copr repo/EPEL7/F23/F24 and rawhide set to Done
  • Checklist item update external_deps.json on 2.7-dev+ to have us bundle this new python-kombu version with releases set to Done

#15 Updated by dkliban@redhat.com almost 5 years ago

  • Status changed from MODIFIED to 5

#16 Updated by dkliban@redhat.com almost 5 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#17 Updated by bmbouter almost 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF