Issue #1386
closed
python-kombu is newer on fedora23, so fedora23 is missing several bugfixes that our patches fix
Added by bmbouter over 8 years ago. Updated about 5 years ago.
Description
In F23, you'll receive 3.0.26-2. This will still run with pulp, but there are a few bugfixes that you may be missing. I'm not sure exactly which ones. To fix the we would need to upgrade to something newer than 3.0.26-2 + patches. If we are going to upgrade, the best thing would be to upgrade to the unreleased 3.0.30 after we test pulp against it. We can ship that with future pulp releases that need to run on f23.
This issue could be purposed to track switching python-kombu to 3.0.30 for F23+
Updated by jortel@redhat.com over 8 years ago
- Severity changed from 2. Medium to 3. High
- Platform Release set to 2.8.0
- Triaged changed from No to Yes
Updated by semyers over 8 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to semyers
I was poking around a little bit, and here's what I've found: 3.0.32 is available on PyPI, but none of our patches apply cleanly against it. Many hunks apply cleanly in reverse, but not all, indicating that they've already been applied. The hunks that don't reverse cleanly, however, could have failed for any number of reasons. The easy solution is to strip out all the patches, but I don't feel familiar enough with them to make that call.
Another issue (and, if we're happy to bump up to kombu 3.0.32, it should literally be another issue) is that kombu 3.0.30+ requires python-amqp >= 1.4.7. We build 1.4.6 in our deps, 1.4.7 is available in fedora updates-testing for fc23, and the latest on PyPI is 1.4.8.
That all said, I built kombu 3.0.32 and amqp 1.4.8 rpms using the latest tarballs from PyPI. pulp master and gofer 2.7 tests all passed, so I'll put together a PR and see what happens. :)
Updated by semyers over 8 years ago
- Related to Task #1368: Include Pulp in the Fedora Project added
Updated by semyers over 8 years ago
amqp 1.4.7 also satisfies the requirements for kombu 3.0.32, and has the bonus of being in fedora already[0], so we got that built on Friday, tested it, and bumped the external deps. This ticket, then, can focus back on upgrading python-kombu.
I manually tested with our spec of python-kombu, modified to apply no patches, and I also tested with the fedora spec of python-kombu, all updated to 3.0.32. All testing was done in a fedora 23 vagrant env.
Here's what I tested:
- Pulp can reconnect to the broker if the broker goes down while pulp is running[1]
- Pulp can connect to the broker is the broker is started after pulp starts[1]
- No ugly exceptions are raised by kombu when pulp is stopped (pstop; watch console and journal)
- ConnectionError is correctly replaced with AuthenticationFailure when authn to qpidd fails[2]
All tests passed.
I also checked that some code clean up file descriptors was in place[3] (it is), and that it has some deadlock prevention code[4] (it isn't).
Overall, 3.0.32 looks good. The deadlock prevention code has been applied to kombu's 3.0 branch, and should be present in kombu 3.0.33 when it's released.
[0]: https://koji.fedoraproject.org/koji/packageinfo?packageID=16456
[1]: https://github.com/PulpQE/pulp-smash/issues/55
[2]: https://github.com/celery/kombu/blob/29ce6322e0f34d57dc989f3467aacf0e936f5753/kombu/transport/qpid.py#L1271-L1298
[3]: https://github.com/celery/kombu/blob/29ce6322e0f34d57dc989f3467aacf0e936f5753/kombu/transport/qpid.py#L1684-1693
[4]: https://github.com/celery/kombu/pull/531/files#diff-d0c727e099ae9547d3b1e3d7a771a1a6
Updated by semyers over 8 years ago
I'm going to test using the kombu commit likely to become 3.0.33 (which includes the deadlock prevention patch).
Updated by semyers over 8 years ago
With 3.0.33 installed, all tests as listed above passed. I also confirmed that in addition to the code to ensure file descriptors are closed, the deadlock prevention code is in-place with 3.0.33.
Updated by bmbouter over 8 years ago
I've requested that the HEAD of celery/kombu:3.0 branch be released as 3.0.33. I think we need to wait until that happens to upgrade our deps.
Updated by semyers over 8 years ago
We've talked about this on the side, but I didn't update the ticket (sorry!).
This is currently blocked awaiting the upstream release of kombu 3.0.33. upstream has been made aware, and we're patiently waiting :)
Updated by bmbouter over 8 years ago
- Related to Issue #1484: celery services do not start on Fedora Server or Fedora Workstation with SELinux enabled added
Updated by bmbouter over 8 years ago
- Related to deleted (Issue #1484: celery services do not start on Fedora Server or Fedora Workstation with SELinux enabled)
Updated by bmbouter over 8 years ago
Upstream kombu has been released[0], but now depends on amqp 1.4.9.
[0]: http://kombu.readthedocs.org/en/latest/changelog.html#version-3-0-33
Updated by semyers about 8 years ago
amqp 1.4.9[0] and kombu 3.0.33[1] are now in rawhide, and will be in fedora 24. There are a few options, but I'm not quite sure how to proceed with regard to fedora23 and the packages we build.
[0]: https://koji.fedoraproject.org/koji/packageinfo?packageID=16456
[1]: https://koji.fedoraproject.org/koji/packageinfo?packageID=12243
Updated by bmbouter about 8 years ago
I propose we carry python-kombu-3.0.33-2 on 2.7-dev and master for fedora 23. That will be the same version as on rawhide which also needs to be rebuilt to 3.0.33-2. The -2 adds in the patch for #1564
Updated by rbarlow about 8 years ago
- Related to deleted (Task #1368: Include Pulp in the Fedora Project)
Updated by pcreech about 8 years ago
Updated python-amqp to 1.4.9-1 [0]
Updated python-kombu to 3.0.33-1.pulp [1]
[0] https://github.com/pulp/pulp/pull/2388
[1] https://github.com/pulp/pulp/pull/2391
Updated by dkliban@redhat.com about 8 years ago
- Status changed from MODIFIED to 5
Updated by dkliban@redhat.com about 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
.