Pulp

Could we replace run-tests.py with tox? I think tox is more standard.

+1 to using tox or some other standard framework for testrunning.

+1 also for using tox or something we don't maintain ourselves.

Do we need tox, or can we just use nosetests directly? The only reason I can think of to use tox is that on some platforms we only want certain unit tests to run. Does tox give us that or can we get nosetests to do it correctly without adding another thing like tox?

bmbouter wrote:

+1 also for using tox or something we don't maintain ourselves.

Do we need tox, or can we just use nosetests directly? The only reason I can think of to use tox is that on some platforms we only want certain unit tests to run. Does tox give us that or can we get nosetests to do it correctly without adding another thing like tox?

Tox also lets you run flake8 etc with the options you want. An example from subscription-manager:

[pep8]
ignore=E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E265,E402,E501,E713,E714,E731
max-line-length=300
[flake8]
ignore=E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E265,E402,E501,E713,E714,E731
exclude=*certdata*,*manifestdata*
jobs=auto
max-line-length=300

I believe we'd be able to get rid of run-tests.py entirely if we can run flake8 and pep8 from tox.

+1 for tox, it will also allow us to run the tests with different versions of python on our own machines.

Upstream celery uses tox to test multiple Python versions. That is awesome. I went to set up the different Python versions on my computer also, but I found it really difficult. I gave up before I got it working.

On 03/05/2015 09:45 AM, bmbouter wrote:> One thing I'm not sure about is
how to list it as a dependency. In

setup.py? In the spec file as a build dep? Is tox available everywhere
and what version? In the developer setup script?

It doesn't belong in setup.py or in the spec file IMO. We could still
have a run-tests.py that is just a thin wrapper around it, and if it
detects that it's missing it gives a helpful error message.

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.