Project

Profile

Help

Task #133 ยป Task #1976 - 2015-03-05T15_56_22Z.eml

rbarlow, 03/05/2015 04:56 PM

 
1
Return-Path: <rbarlow@redhat.com>
2
Received: from mi028.mc1.hosteurope.de ([80.237.138.227]) by wp245.webpack.hosteurope.de running ExIM with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1YTY8E-0004ZA-Bf; Thu, 05 Mar 2015 16:56:14 +0100
3
Received: from mx1.redhat.com ([209.132.183.28]) by mx0.webpack.hosteurope.de (mi028.mc1.hosteurope.de) with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) id 1YTY8D-0007HK-DB for dropbox+pulp+c71e@plan.io; Thu, 05 Mar 2015 16:56:14 +0100
4
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t25Fu8I5010801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for <dropbox+pulp+c71e@plan.io>; Thu, 05 Mar 2015 10:56:08 -0500
5
Received: from where.usersys.redhat.com (ovpn-113-99.phx2.redhat.com [10.3.113.99]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t25Fu7wr029340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for <dropbox+pulp+c71e@plan.io>; Thu, 05 Mar 2015 10:56:07 -0500
6
Date: Thu, 05 Mar 2015 10:56:06 -0500
7
From: Randy Barlow <rbarlow@redhat.com>
8
To: Pulp <dropbox+pulp+c71e@plan.io>
9
Message-ID: <54F87C96.505@redhat.com>
10
In-Reply-To: <redmine.journal-1973.20150305144552.7dc9a809758f4b0f@plan.io>
11
References: <redmine.issue-133.20150122214605@plan.io>
12
 <redmine.journal-1973.20150305144552.7dc9a809758f4b0f@plan.io>
13
Subject: Re: [Pulp - Task #133] Make ./run-tests.py pass through arguments to
14
 nosetests
15
Mime-Version: 1.0
16
Content-Type: text/plain;
17
 charset=utf-8
18
Content-Transfer-Encoding: quoted-printable
19
Delivery-date: Thu, 05 Mar 2015 16:56:14 +0100
20
Organization: Red Hat, Inc.
21
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
22
 Thunderbird/31.5.0
23
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
24
X-HE-Spam-Level: ----------
25
X-HE-Spam-Score: -10.0
26
X-HE-Spam-Report: Content analysis details: (-10.0 points) pts rule name
27
 description ---- ----------------------
28
 -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL:
29
 Sender listed at http://www.dnswl.org/, high trust [209.132.183.28 listed in
30
 list.dnswl.org] -5.0 PGP_MESSAGE RAW: Contains a PGP signed or encrypted
31
 message
32
X-HE-SPF: PASSED
33
Envelope-to: dropbox+pulp+c71e@plan.io
34

    
35
On 03/05/2015 09:45 AM, bmbouter wrote:> One thing I'm not sure about is
36
how to list it as a dependency. In
37
> setup.py? In the spec file as a build dep? Is tox available everywhere
38
> and what version? In the developer setup script?
39

    
40
It doesn't belong in setup.py or in the spec file IMO. We could still
41
have a run-tests.py that is just a thin wrapper around it, and if it
42
detects that it's missing it gives a helpful error message.
43
> --- Please write your response above this line ---
44
> =
45

    
46
> Issue #133 has been updated by bmbouter.
47
> =
48

    
49
>   * *Description* updated (diff
50
>     <https://pulp.plan.io/journals/diff/1973?detail_id=889>)
51
> =
52

    
53
> I rewrote the story based on the tox discussion.
54
> =
55

    
56
> One thing I'm not sure about is how to list it as a dependency. In
57
> setup.py? In the spec file as a build dep? Is tox available everywhere
58
> and what version? In the developer setup script?
59
> =
60

    
61
> -----------------------------------------------------------------------=
62
-
63
> =
64

    
65
> =
66

    
67
>   Task #133: Make ./run-tests.py pass through arguments to nosetests
68
>   <https://pulp.plan.io/issues/133#change-1973>
69
> =
70

    
71
>   * Author: bmbouter
72
>   * Status: NEW
73
>   * Priority: Normal
74
>   * Assignee:
75
>   * Category:
76
>   * Sprint/Milestone:
77
>   * Backwards Incompatible:
78
>   * Tags: Sprint Candidate
79
>   * QA Contact: =
80

    
81
> =
82

    
83
> *Motivation*
84
> This is a task to replace the ./run-tests.py modules in platform AND al=
85
l
86
> plugins. Developers should be able to pass arguments to ./run-tests.py
87
> and have it pass them through to nose. We could fix that defect, or we
88
> could stop maintaining run-tests.py and use tox instead.
89
> =
90

    
91
> *Requirements*
92
> =
93

    
94
>  1. Remove run-tests.py in platform and all plugins
95
>  2. Remove pulp.devel.test_runner
96
>  3. List tox as a developer dependency somehow (I'm a little unclear on=
97

    
98
>     where to put this)
99
>  4. Add a tox configuration to platform and plugins which provides the
100
>     same behaviors (flake8, test selection based on OS, etc).
101
>  5. Update the development docs accordingly.
102
>  6. Consider if any changes need to be done to the dev setup scripts to=
103

    
104
>     accommodate this
105
> =
106

    
107
> -----------------------------------------------------------------------=
108
-
109
> =
110

    
111
> You have received this notification because you have either subscribed
112
> to or are involved in a project on Pulp Planio.
113
> To change your notification preferences, please click here:
114
> https://pulp.plan.io/my/account
115
> =
116

    
117
> 	=
118

    
119
> =
120

    
121
> This notification was cheerfully delivered by <https://plan.io/>
122
> 	=
123

    
124
> Planio <https://plan.io/>
125
> =
126

    
127

    
128

    
129
-- =
130

    
131
Randy Barlow
    (1-1/1)