|
Return-Path: <rbarlow@redhat.com>
|
|
Received: from mi028.mc1.hosteurope.de ([80.237.138.227]) by wp245.webpack.hosteurope.de running ExIM with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1YTY8E-0004ZA-Bf; Thu, 05 Mar 2015 16:56:14 +0100
|
|
Received: from mx1.redhat.com ([209.132.183.28]) by mx0.webpack.hosteurope.de (mi028.mc1.hosteurope.de) with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) id 1YTY8D-0007HK-DB for dropbox+pulp+c71e@plan.io; Thu, 05 Mar 2015 16:56:14 +0100
|
|
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t25Fu8I5010801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for <dropbox+pulp+c71e@plan.io>; Thu, 05 Mar 2015 10:56:08 -0500
|
|
Received: from where.usersys.redhat.com (ovpn-113-99.phx2.redhat.com [10.3.113.99]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t25Fu7wr029340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for <dropbox+pulp+c71e@plan.io>; Thu, 05 Mar 2015 10:56:07 -0500
|
|
Date: Thu, 05 Mar 2015 10:56:06 -0500
|
|
From: Randy Barlow <rbarlow@redhat.com>
|
|
To: Pulp <dropbox+pulp+c71e@plan.io>
|
|
Message-ID: <54F87C96.505@redhat.com>
|
|
In-Reply-To: <redmine.journal-1973.20150305144552.7dc9a809758f4b0f@plan.io>
|
|
References: <redmine.issue-133.20150122214605@plan.io>
|
|
<redmine.journal-1973.20150305144552.7dc9a809758f4b0f@plan.io>
|
|
Subject: Re: [Pulp - Task #133] Make ./run-tests.py pass through arguments to
|
|
nosetests
|
|
Mime-Version: 1.0
|
|
Content-Type: text/plain;
|
|
charset=utf-8
|
|
Content-Transfer-Encoding: quoted-printable
|
|
Delivery-date: Thu, 05 Mar 2015 16:56:14 +0100
|
|
Organization: Red Hat, Inc.
|
|
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
|
|
Thunderbird/31.5.0
|
|
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
|
|
X-HE-Spam-Level: ----------
|
|
X-HE-Spam-Score: -10.0
|
|
X-HE-Spam-Report: Content analysis details: (-10.0 points) pts rule name
|
|
description ---- ----------------------
|
|
-------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL:
|
|
Sender listed at http://www.dnswl.org/, high trust [209.132.183.28 listed in
|
|
list.dnswl.org] -5.0 PGP_MESSAGE RAW: Contains a PGP signed or encrypted
|
|
message
|
|
X-HE-SPF: PASSED
|
|
Envelope-to: dropbox+pulp+c71e@plan.io
|
|
|
|
On 03/05/2015 09:45 AM, bmbouter wrote:> One thing I'm not sure about is
|
|
how to list it as a dependency. In
|
|
> setup.py? In the spec file as a build dep? Is tox available everywhere
|
|
> and what version? In the developer setup script?
|
|
|
|
It doesn't belong in setup.py or in the spec file IMO. We could still
|
|
have a run-tests.py that is just a thin wrapper around it, and if it
|
|
detects that it's missing it gives a helpful error message.
|
|
> --- Please write your response above this line ---
|
|
> =
|
|
|
|
> Issue #133 has been updated by bmbouter.
|
|
> =
|
|
|
|
> * *Description* updated (diff
|
|
> <https://pulp.plan.io/journals/diff/1973?detail_id=889>)
|
|
> =
|
|
|
|
> I rewrote the story based on the tox discussion.
|
|
> =
|
|
|
|
> One thing I'm not sure about is how to list it as a dependency. In
|
|
> setup.py? In the spec file as a build dep? Is tox available everywhere
|
|
> and what version? In the developer setup script?
|
|
> =
|
|
|
|
> -----------------------------------------------------------------------=
|
|
-
|
|
> =
|
|
|
|
> =
|
|
|
|
> Task #133: Make ./run-tests.py pass through arguments to nosetests
|
|
> <https://pulp.plan.io/issues/133#change-1973>
|
|
> =
|
|
|
|
> * Author: bmbouter
|
|
> * Status: NEW
|
|
> * Priority: Normal
|
|
> * Assignee:
|
|
> * Category:
|
|
> * Sprint/Milestone:
|
|
> * Backwards Incompatible:
|
|
> * Tags: Sprint Candidate
|
|
> * QA Contact: =
|
|
|
|
> =
|
|
|
|
> *Motivation*
|
|
> This is a task to replace the ./run-tests.py modules in platform AND al=
|
|
l
|
|
> plugins. Developers should be able to pass arguments to ./run-tests.py
|
|
> and have it pass them through to nose. We could fix that defect, or we
|
|
> could stop maintaining run-tests.py and use tox instead.
|
|
> =
|
|
|
|
> *Requirements*
|
|
> =
|
|
|
|
> 1. Remove run-tests.py in platform and all plugins
|
|
> 2. Remove pulp.devel.test_runner
|
|
> 3. List tox as a developer dependency somehow (I'm a little unclear on=
|
|
|
|
> where to put this)
|
|
> 4. Add a tox configuration to platform and plugins which provides the
|
|
> same behaviors (flake8, test selection based on OS, etc).
|
|
> 5. Update the development docs accordingly.
|
|
> 6. Consider if any changes need to be done to the dev setup scripts to=
|
|
|
|
> accommodate this
|
|
> =
|
|
|
|
> -----------------------------------------------------------------------=
|
|
-
|
|
> =
|
|
|
|
> You have received this notification because you have either subscribed
|
|
> to or are involved in a project on Pulp Planio.
|
|
> To change your notification preferences, please click here:
|
|
> https://pulp.plan.io/my/account
|
|
> =
|
|
|
|
> =
|
|
|
|
> =
|
|
|
|
> This notification was cheerfully delivered by <https://plan.io/>
|
|
> =
|
|
|
|
> Planio <https://plan.io/>
|
|
> =
|
|
|
|
|
|
|
|
-- =
|
|
|
|
Randy Barlow
|
.