Issue #1278
closedno error if content source conf file is not readable
Description
I inadvertently created a conf file in /etc/pulp/content/sources/conf.d with permissions of 600 instead of 644. When I ran 'pulp-admin content sources list', it simply showed that there were no content sources instead of returning an error. This caused a couple of hours of debugging on my part to find my mistake.
Ideally, the load_all() function in model.py will throw an exception if it tries to read a conf file that is not readable.
Updated by mhrivnak over 8 years ago
- Severity changed from 2. Medium to 3. High
- Platform Release set to 2.8.0
- Triaged changed from No to Yes
Updated by jortel@redhat.com over 8 years ago
This appears to be a bug in ConfigParser.read(). As a workaround, I suggest adding:
if not os.access(path, os.R_OK):
<log something>
continue
immediately following the check to see if it is a file.
If confirmed that this is in ConfigParser, let's file a bug on it upstream.
Updated by mhrivnak over 8 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to mhrivnak
Updated by mhrivnak over 8 years ago
ConfigParser has unconventional behavior; we have not discovered a bug in it. The read() function returns a list of files that were successfully read, and we were ignoring that list. There is a reasonable explanation detailed here: https://docs.python.org/2/library/configparser.html#ConfigParser.RawConfigParser.read
Updated by mhrivnak over 8 years ago
- Status changed from ASSIGNED to POST
Added by mhrivnak over 8 years ago
Added by mhrivnak over 8 years ago
Revision 02bdb173 | View on GitHub
log a warning when a content source config file cannot be read
fixes #1278
Updated by mhrivnak over 8 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset pulp|02bdb17393873ac2321f6ab1ccb3ef795416a36d.
Updated by dkliban@redhat.com about 8 years ago
- Status changed from MODIFIED to 5
Updated by dkliban@redhat.com almost 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
log a warning when a content source config file cannot be read
fixes #1278