Project

Profile

Help

Refactor #114

pulp/server/pulp/server/initialization.py unnecessarily imports kombu.transport.qpid

Added by bmbouter almost 5 years ago. Updated 9 months ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

100%

Platform Release:
2.7.0
Blocks Release:
Groomed:
Yes
Sprint Candidate:
Yes
Tags:
Pulp 2
Complexity:
Verified:
Yes
Verification Required:
No
Sprint:
March 2015

Description

TODO:
1. Remove the comment and import line here [0].
2. Run tests and fix any test failures.

Pulp used to have a workaround whereby kombu.transport.qpid would have to be imported early on in the Pulp initialization process. This was required so that monkey patches were applied to class objects before execution actually began. That is no longer required, and this should be removed.

[0]: https://github.com/pulp/pulp/blob/cc8ec0cae37a38793d7ebc784e83bd969e6e585a/server/pulp/server/initialization.py#L31-33

Associated revisions

History

#1 Updated by bmbouter almost 5 years ago

  • Tags Sprint Candidate added

#2 Updated by cduryee almost 5 years ago

Good catch, thanks for remembering to remove this:)

#3 Updated by mhrivnak almost 5 years ago

  • Priority changed from Normal to Low

#4 Updated by bmbouter almost 5 years ago

  • Tags Groomed added

#5 Updated by rbarlow almost 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to rbarlow

#6 Updated by rbarlow almost 5 years ago

  • Platform Release set to master

#7 Updated by rbarlow almost 5 years ago

  • Status changed from ASSIGNED to POST
  • Sprint/Milestone set to 14

#8 Updated by rbarlow almost 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#9 Updated by rbarlow almost 5 years ago

  • Platform Release changed from master to 2.7.0

#10 Updated by bmbouter over 4 years ago

  • Groomed set to Yes
  • Tags deleted (Groomed)

#11 Updated by bmbouter over 4 years ago

  • Sprint Candidate set to Yes
  • Tags deleted (Sprint Candidate)

#12 Updated by dkliban@redhat.com over 4 years ago

  • Status changed from MODIFIED to ON_QA

#13 Updated by Skullman over 4 years ago

  • Status changed from ON_QA to VERIFIED

#15 Updated by rbarlow about 4 years ago

  • Status changed from VERIFIED to CLOSED - CURRENTRELEASE

#16 Updated by pulpbot almost 3 years ago

  • Verified changed from No to Yes

#17 Updated by bmbouter almost 2 years ago

  • Sprint set to March 2015

#18 Updated by bmbouter almost 2 years ago

  • Sprint/Milestone deleted (14)

#19 Updated by bmbouter 9 months ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF