Issue #9563
closed
It should not be necessary to provide the base url to utilize a AptReleaseSigningService
Description
Using a AsciiArmoredDetachedSigningService it suffices to provide the pulp_href whilst the AptReleaseSigningService wants you to provide the full path.
i.e. http://yourpulphost.com/{pulp_href}
It's relatively hard to pin the base_path when having multiple environments. It would be really great if we only have to pass the pulp_href.
Updated by quba42 over 2 years ago
I had a look at how pulp_deb and pulp_rpm use signing services and noticed the following:
The AptPublicationSerializer uses the following field relation in pulp_deb/app/serializers/publication_serializers.py:
signing_service = HyperlinkedRelatedField(
help_text="Sign Release files with this signing key",
many=False,
queryset=AptReleaseSigningService.objects.all(),
view_name="signing-services-detail",
required=False,
)
The corresponding RPM serializer uses just RelatedField instead of HyperlinkedRelatedField.
I suspect this is the root cause of the bug, but I have not yet had a chance to test it.
Updated by quba42 over 2 years ago
No time... Other things keep taking priority over this.
Added by Joshua Schmid over 2 years ago
Updated by Anonymous over 2 years ago
- Status changed from NEW to MODIFIED
Applied in changeset f252699f8424451e0303947d86a0f7ccc9e0c387.
Added by Joshua Schmid over 2 years ago
Revision 3e520222 | View on GitHub
Use RelatedField for signing services
closes #9563
The field referencing a signing service on a publication now uses pulpcore.plugin.serializers.RelatedField, rather than: rest_framework.serializers.HyperlinkedRelatedField
The latter was causing a full URL to be stored, which in turn causes various usability issues and is inconsistent with everything else in Pulp (which use pulp_href only).
Signed-off-by: Joshua Schmid jaiks@posteo.de
Updated by pulpbot over 2 years ago
- Status changed from MODIFIED to CLOSED - CURRENTRELEASE
.
Use RelatedField for signing services
closes #9563
The field referencing a signing service on a publication now uses pulpcore.plugin.serializers.RelatedField, rather than: rest_framework.serializers.HyperlinkedRelatedField
The latter was causing a full URL to be stored, which in turn causes various usability issues and is inconsistent with everything else in Pulp (which use pulp_href only).